refactor: make SAML apps to be first party apps #6913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darcyYe
requested review from
wangsijie,
charIeszhao,
xiaoyijun,
gao-sun and
simeng-li
as code owners
COMPARE TO
|
| Name | Diff |
|---|---|
| packages/console/src/components/ApplicationIcon/index.tsx | 📈 +75 Bytes |
| packages/core/src/saml-applications/routes/index.ts | 📈 +30 Bytes |
| packages/schemas/alterations/next-1735292380-make-saml-app-first-party-app.ts | 📈 +796 Bytes |
| packages/schemas/tables/applications.sql | 📈 +129 Bytes |
darcyYe
force-pushed
the
yemq-make-saml-app-first-party-app
branch
from
4fd50c5 to
dd0e129
Compare
wangsijie
approved these changes
Jan 6, 2025
darcyYe
force-pushed
the
yemq-make-saml-app-first-party-app
branch
from
dd0e129 to
de0854f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
make SAML apps to be first party apps (resolves LOG-10650)
Testing
Tested locally.
Checklist
.changeset