Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added helper functions for channel and user lists to make the API a bit ... #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dannyquist
Copy link

...more friendly

Added support for the following methods: chat.delete, chat.update, channel.history, channel.list, users.list, auth.text, channels.info, channels.invite, channels.join, channels.leave, channels.mark, channels.setPurpose, channels.setTopic, emoji.list, stars.list

I hope you'll forgive a slight reordering of some of your original code

…it more friendly

Added support for the following methods: chat.delete, chat.update, channel.history, channel.list, users.list, auth.text, channels.info, channels.invite, channels.join, channels.leave, channels.mark, channels.setPurpose, channels.setTopic, emoji.list, stars.list



def chat_post_message(self, channel, text, username="cirtbot", **params):
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"cirtbot"? Let's keep username optional, eh?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, sorry about that.

@loisaidasam
Copy link
Owner

Many great additions, thank you for your work! I have a few comments, but otherwise looks pretty good 👍

@dannyquist
Copy link
Author

No problem and thanks for the comments. I hope it was useful and everything you suggested makes sense.

@chrisgilbert
Copy link

Hey there, any chance this could be merged? I used your library for my first slack script, but needed a few more features like setTopic for the channel, so switched to slackclient instead. After some frustration in that it doesn't do much in terms of error handling and so on, I though it would be great if I could carry on using your lib instead. I'm happy to contribute back fixes and patches if required.

@dannyquist
Copy link
Author

By all means feel free.

@loisaidasam
Copy link
Owner

Nice - I had some comments a few months back - if you could attend to those I'd be happy to merge in the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants