-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added helper functions for channel and user lists to make the API a bit ... #6
base: master
Are you sure you want to change the base?
Conversation
…it more friendly Added support for the following methods: chat.delete, chat.update, channel.history, channel.list, users.list, auth.text, channels.info, channels.invite, channels.join, channels.leave, channels.mark, channels.setPurpose, channels.setTopic, emoji.list, stars.list
|
||
|
||
|
||
def chat_post_message(self, channel, text, username="cirtbot", **params): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"cirtbot"? Let's keep username optional, eh?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops, sorry about that.
Many great additions, thank you for your work! I have a few comments, but otherwise looks pretty good 👍 |
No problem and thanks for the comments. I hope it was useful and everything you suggested makes sense. |
Hey there, any chance this could be merged? I used your library for my first slack script, but needed a few more features like setTopic for the channel, so switched to slackclient instead. After some frustration in that it doesn't do much in terms of error handling and so on, I though it would be great if I could carry on using your lib instead. I'm happy to contribute back fixes and patches if required. |
By all means feel free. |
Nice - I had some comments a few months back - if you could attend to those I'd be happy to merge in the changes. |
...more friendly
Added support for the following methods: chat.delete, chat.update, channel.history, channel.list, users.list, auth.text, channels.info, channels.invite, channels.join, channels.leave, channels.mark, channels.setPurpose, channels.setTopic, emoji.list, stars.list
I hope you'll forgive a slight reordering of some of your original code