Skip to content

Commit

Permalink
Merge pull request #442 from lona-web-org/fscherf/fix-rendering-issue
Browse files Browse the repository at this point in the history
fix rendering issue
  • Loading branch information
fscherf authored Jul 17, 2023
2 parents 363b389 + 3cd59e6 commit e865598
Show file tree
Hide file tree
Showing 4 changed files with 195 additions and 167 deletions.
1 change: 1 addition & 0 deletions lona/client2/_lona/client2/rendering-engine.js
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,7 @@ export class LonaRenderingEngine {
node.remove();

this._remove_widget_if_present(node_id);
this._clean_node_cache();
};

_remove_widget_if_present(node_id) {
Expand Down
11 changes: 9 additions & 2 deletions lona/logging.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
terminal_supports_colors,
colors_are_enabled,
)
from lona.errors import ClientError

try:
# syslog is only on unix based systems available
Expand Down Expand Up @@ -62,10 +63,11 @@ def exclude(self, logger_name):
self.excluded.append(logger_name)

def filter(self, record):
# filter exceptions that lona.command_line.run_server.run_server
# handles it self
if record.exc_info:

# filter exceptions that lona.command_line.run_server.run_server
# handles it self

# OSErrors
if (isinstance(record.exc_info[1], OSError) and
record.exc_info[1].errno in (13, 98)):
Expand All @@ -78,6 +80,11 @@ def filter(self, record):

return False

# filter exceptions that Lona logs it-self to avoid
# duplicate logs
if isinstance(record.exc_info[1], ClientError):
return False

if record.name == 'lona':
# The lona root logger is used by the command line tools
# to report errors, for example when startup is not possible due
Expand Down
Loading

0 comments on commit e865598

Please sign in to comment.