python: drop support for 3.7 #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fscherf
force-pushed
the
fscherf/remove-python37-support
branch
from
fff0246
to
4f0ead3
Compare
sobolevn
approved these changes
Jul 3, 2023
There was a problem hiding this comment.
You can also run pyupgrade if you wish (. It sometimes does good things to your code.
And don't forget to change mypy: https://github.com/lona-web-org/lona/blob/master/mypy.ini#L3
Since 27. Jun 2023, Python 3.7 is end of life (https://endoflife.date/python). Thus, this patch removes support for this version. Signed-off-by: Florian Scherf <mail@florianscherf.de>
fscherf
force-pushed
the
fscherf/remove-python37-support
branch
from
4f0ead3
to
f632500
Compare
Nice tool! I ran it and it seems to be happy with the code.
Good call. Fixed. |
|
@sobolevn: Thanks for reviewing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 27. Jun 2023, Python 3.7 is end of life (https://endoflife.date/python). Thus, this patch removes support for this version.