Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix rendering issue #442

Merged
merged 2 commits into from
Jul 17, 2023
Merged

fix rendering issue #442

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
919a618
logging: remove obsolete information when logging ClientError exceptions
fscherf Jul 13, 2023
3cd59e6
client2: rendering: fix crash when moving a node
fscherf Jul 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lona/client2/_lona/client2/rendering-engine.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,7 @@ export class LonaRenderingEngine {
node.remove();

this._remove_widget_if_present(node_id);
this._clean_node_cache();
};

_remove_widget_if_present(node_id) {
Expand Down
11 changes: 9 additions & 2 deletions lona/logging.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
terminal_supports_colors,
colors_are_enabled,
)
from lona.errors import ClientError

try:
# syslog is only on unix based systems available
Expand Down Expand Up @@ -62,10 +63,11 @@ def exclude(self, logger_name):
self.excluded.append(logger_name)

def filter(self, record):
# filter exceptions that lona.command_line.run_server.run_server
# handles it self
if record.exc_info:

# filter exceptions that lona.command_line.run_server.run_server
# handles it self

# OSErrors
if (isinstance(record.exc_info[1], OSError) and
record.exc_info[1].errno in (13, 98)):
Expand All @@ -78,6 +80,11 @@ def filter(self, record):

return False

# filter exceptions that Lona logs it-self to avoid
# duplicate logs
if isinstance(record.exc_info[1], ClientError):
return False

if record.name == 'lona':
# The lona root logger is used by the command line tools
# to report errors, for example when startup is not possible due
Expand Down
Loading