views: issue warning on use of .daemonize #458
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #458 +/- ##
==========================================
- Coverage 73.16% 71.81% -1.35%
==========================================
Files 88 84 -4
Lines 6103 5776 -327
Branches 1326 1083 -243
==========================================
- Hits 4465 4148 -317
+ Misses 1357 1353 -4
+ Partials 281 275 -6 ☔ View full report in Codecov by Sentry. |
|
No need to change this for this PR, but shouldn't we issue deprecation warning at all the other soon-to-be-deprecated features, too? Edit: I see @fscherf has already commented on this in another PR :-) So just go ahed. |
|
I'll try to update this with more warnings, but of course there is plenty of room for error, because I don't understand all of the code. On deprecated routines I will have have warning issued in the body of the routine not in the callers place (e.g. |
AvdN
force-pushed
the
daemonize_deprecation-2
branch
2 times, most recently
from
0d1a6b1
to
9e0276f
Compare
|
@SmithChart, @AvdN: I created #468 with a roadmap. The PR still needs review, but I think you can use the list of tasks for Lona 2 to create warnings and deprecations |
lona/compat.py
Outdated
| @@ -14,6 +16,7 @@ | |||
| def get_client_version(): | |||
| # TODO: remove in 2.0 | |||
|
|
|||
| lona.warnings.remove_2_0() | |||
There was a problem hiding this comment.
All warnings in this module are incorrect because they run no matter what the user does, and are meant to remain compatible with old API. The TODO: remove in 2.0 is only there so we don't forget to remove the functions before releasing Lona 2
lona/view_runtime.py
Outdated
| @@ -123,6 +123,8 @@ def __init__( | |||
|
|
|||
| # TODO: remove in 2.0 | |||
| # compatibility for older Lona application code | |||
| if hasattr(self.view, 'STOP_DAEMON_WHEN_VIEW_FINISHES'): | |||
There was a problem hiding this comment.
This is a feature flag. Not using it should not result in a deprecation warning
|
@AvdN: This PR has been open for a long time now. Should I just take over and add the last fixes? |
|
Hi @fscherf, yes please, I am not sure why I didn't react to this at the first request. Sorry for that. |
|
@AvdN: There is nothing to be sorry about :) |
add deprecation warning add intermediary Lona_2_0_DeprecationWarning so only one warnings needs to be set for filtering. update example code
fscherf
force-pushed
the
daemonize_deprecation-2
branch
from
e325229
to
0ff6921
Compare
|
@AvdN: merged! I am so sorry that it took me so long. The test suite was broken for a long time and it took me a long time to understand why. Thanks for contributing, and for your patience! |
add deprecation warning
add intermediary Lona_2_0_DeprecationWarning so only one warnings needs to be set for filtering.
update example code