setup live reload #473
Merged
setup live reload #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fscherf
requested review from
korantu,
markusgritsch,
grigolet,
sobolevn,
SmithChart and
m-reichle
fscherf
force-pushed
the
fscherf/live-reload
branch
from
73153fd
to
835a775
Compare
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #473 +/- ##
==========================================
- Coverage 72.74% 71.72% -1.03%
==========================================
Files 84 84
Lines 5746 5761 +15
Branches 1235 1238 +3
==========================================
- Hits 4180 4132 -48
- Misses 1301 1349 +48
- Partials 265 280 +15
☔ View full report in Codecov by Sentry. |
This patch adds live reload to Lona server, based on watchfiles.
Because watchfiles requires scripts to use
if __name__ == '__main__':
pass
this patch also updates all examples that show Lona scripts.
Signed-off-by: Florian Scherf <mail@florianscherf.de>
fscherf
force-pushed
the
fscherf/live-reload
branch
2 times, most recently
from
e4f15eb
to
43a2d7e
Compare
Signed-off-by: Florian Scherf <mail@florianscherf.de>
fscherf
force-pushed
the
fscherf/live-reload
branch
from
43a2d7e
to
4c6d63e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jup, you read that right and I am eating my hat on this one.
I stated pretty loudly that I am against a live reload feature, but I have to admit that watchfiles works pretty good these days and the feature is pretty neat.