Skip to content

Commit

Permalink
chore: shorten hack required checks sleep (#735)
Browse files Browse the repository at this point in the history
* chore: shorten hack required checks sleep

all CI jobs seem to be finishing well within 5 minutes and failing
jobs will generally finish sooner anyway

* Update .github/workflows/required-checks-hack-ci.yml

Co-authored-by: John Kaster <kaster@google.com>

Co-authored-by: John Kaster <kaster@google.com>
  • Loading branch information
joeldodge79 and jkaster authored Jul 7, 2021
1 parent a93a9b1 commit 47ea87c
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions .github/workflows/required-checks-hack-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,31 +45,31 @@ jobs:
name: Codegen Tests
runs-on: ubuntu-latest
steps:
# using `sleep 900` as a naive solution to avoiding early approval: 99% of
# real CI jobs finish in under 15 minutes. Waiting 15 minutes here should
# using `sleep 480` as a naive solution to avoiding early approval: 99% of
# real CI jobs finish in under 8 minutes. Waiting 8 minutes here should
# mostly avoid the scenario where these noop jobs meet all required checks
# on a PR prior to a corresponding real CI job being able to report.
#
# A more elegant hack to this github-lack-of-configurable-required-checks
# might be to run a script with https://github.com/octokit/action.js/
# that uses either the REST or GraphQL API to figure out when all
# outstanding workflows for this PR have finished and only then `exit 0`
- run: sleep 900 && exit 0
- run: sleep 480 && exit 0

noop-typescript-results:
name: Typescript Tests
runs-on: ubuntu-latest
steps:
- run: sleep 900 && exit 0
- run: sleep 480 && exit 0

noop-python-results:
name: Python Tests
runs-on: ubuntu-latest
steps:
- run: sleep 900 && exit 0
- run: sleep 480 && exit 0

noop-apix-results:
name: APIX Tests
runs-on: ubuntu-latest
steps:
- run: sleep 900 && exit 0
- run: sleep 480 && exit 0

0 comments on commit 47ea87c

Please sign in to comment.