Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: generate SDKs for Looker 24.0 #1426

Merged
merged 1 commit into from
Feb 1, 2024
Merged

feat: generate SDKs for Looker 24.0 #1426

merged 1 commit into from
Feb 1, 2024

Conversation

drstrangelooker
Copy link
Collaborator

I disabled the pre-commit hook in order to get this to build. Please look at diffs closely to see if it looks good.

Release-As: 24.0.0

@drstrangelooker
Copy link
Collaborator Author

My output @jeremytchang @jkaster

$ bin/sdk_gen 24.0                                                                                                                 
/usr/local/google/home/drstrangelove/sdk-codegen/bin/sdk_gen <version>                                                                                                              
  version: Looker release version, like 22.10                                                                                                                                       
Generating SDKs for Looker 24.0 ...                                                                                                                                                 
fatal: 'refs/heads/sdk_24_0' - not a valid ref                                                                                                                                      
Creating branch sdk_24_0 ...                                                                                                                                                        
Running git checkout -b sdk_24_0 origin/main ...                                                                                                                                    
Switched to a new branch 'sdk_24_0'                                                                                                                                                 
Running yarn gen ...                                                                                                                                                                
Error: the command black could not be found within PATH or Pipfile's [scripts].                                                                                                     
Running bin/smoke typescript python kotlin ...                                                                                                                                      
PASS packages/sdk-rtl/src/delimArray.spec.ts                                                                                                                                        
PASS packages/sdk-rtl/src/browserTransport.spec.ts                                                                                                                                  
PASS packages/sdk-rtl/src/browserSession.spec.ts                                                                                                                                    
PASS packages/sdk-rtl/src/transport.spec.ts                                                                                                                                         
PASS packages/sdk-rtl/src/extensionSession.spec.ts                                                                                                                                  
PASS packages/sdk-rtl/src/paging.spec.ts
PASS packages/sdk-rtl/src/errorDoc.spec.ts                                                                                                                                 [57/9447]
PASS packages/sdk-rtl/src/constants.spec.ts                                                                                                                                         
PASS packages/sdk-rtl/src/authToken.spec.ts                                                                                                                                         
PASS packages/sdk-rtl/src/apiMethods.spec.ts                                                                                                                                        
PASS packages/sdk-rtl/src/extensionTransport.spec.ts                                                                                                                                
PASS packages/sdk-rtl/src/browserServices.spec.ts                                                                                                                                   
PASS packages/sdk-rtl/src/proxySession.spec.ts                                                                                                                                      
PASS packages/sdk-rtl/src/apiSettings.spec.ts                                                                                                                                       
PASS packages/sdk-rtl/src/oauthSession.spec.ts                                                                                                                                      
                                                                                                                                                                                    
Test Suites: 15 passed, 15 total                                                                                                                                                    
Tests:       104 passed, 104 total                                                                                                                                                  
Snapshots:   0 total                                                                                                                                                                
Time:        5.597 s                                                                                                                                                                
Ran all test suites matching /packages\/sdk-rtl/i.                                                                                                                                  
Loading .env environment variables...                                                                                                                                               
Error: the command tox could not be found within PATH or Pipfile's [scripts].                                                                                                       
                                                                                                                                                                                    
38 tests completed, 2 failed                                                                                                                                                        
                                                                                                                                                                                    
FAILURE: Build failed with an exception.                                                                                                                                            
                                                                                                                                                                                    
* What went wrong:                                                                                                                                                                  
Execution failed for task ':test'.                                                                                                                                                  
> There were failing tests. See the report at: file:///usr/local/google/home/drstrangelove/sdk-codegen/kotlin/build/reports/tests/test/index.html                                   
                                                                                                                                                                                    
* Try:                                                                                                                                                                              
> Run with --scan to get full insights.                                                                                                                                             
                                                                                                                                                                                    
BUILD FAILED in 12s                                                                                                                                                                 
PASS packages/sdk-node/test/methods.spec.ts (21.163 s)                                                                                                                              
  LookerNodeSDK                                                                                                                                                                     
    ✓ assigns SDK.ApiVersion (6 ms)                                                                                                                                                 
    issue-related tests                                                                                                                                                             
      ✓ create_user_attribute options (197 ms)                                                                                                                                      
    downloads                                                                                                                                                                       
      ✓ png and svg (207 ms)                                                                                                                                                        
    PUT smoke test                                                                                                                                                                  
      ✓ set default color collection (316 ms)                                                                                                                                       
    automatic authentication for API calls                                                                                                                                          
      ✓ me returns the correct result (131 ms)                                                                                                                                      
      ✓ me fields filter (142 ms)                                                                                                                                                   
    sudo                                                                                                                                                                            
      ✓ login/logout (1356 ms)                                                                                                                                                      
    retrieves collections                                                                                                                                                           
      ✓ search_looks returns looks (224 ms)                                                                                                                                         
      ✓ search_looks fields filter (164 ms)                                                                                                                                         
      ✓ search_looks fields and title (230 ms)                                                                                                                                      
    User CRUD-it checks                                                                                                                                                             
      ✓ create, update, and delete user (4344 ms)                                                                                                                                   
    User searches                                                                                                                                                                   
      ✓ bad search returns no results (134 ms)                                                                                                                                      
      ✓ matches email domain (195 ms)                                                                                                                                               
      ✓ csv user id list aka DelimArray (316 ms)                                                                                                                                    
      ✓ matches email domain and returns sorted (355 ms)                                                                                                                            
    Datagroups                                                                                                                                                                      
      ✓ gets all datagroups (116 ms)
    Types with enums                                                                                                                                                        [0/9447]
      ✓ CreateQueryTask serializes and deserializes (1 ms)
    paging alpha
      pager
        ○ skipped getRel can override limit and offset
        ○ skipped observers can be chained
      pageAll
        ○ skipped search_dashboard
        ○ skipped all_dashboards pageAll returns non-paged results
    Query calls
      ✓ create and run query (864 ms)
      ✓ run_inline_query (943 ms)
      ✓ parses a query with no results (2802 ms)
    Dashboard endpoints
      ✓ search_dashboards (340 ms)
      ✓ create and update dashboard (1015 ms)
    Theme
      ✓ validate_theme returns ok on valid template (117 ms)
      ✓ validate_theme throws error with details (65 ms)
    Node environment
      ✓ no INI (156 ms)

Test Suites: 1 passed, 1 total
Tests:       4 skipped, 25 passed, 29 total
Snapshots:   0 total
Time:        21.665 s, estimated 22 s
Ran all test suites matching /packages\/sdk-node\/test/i.
Loading .env environment variables...
Error: the command tox could not be found within PATH or Pipfile's [scripts].

8 tests completed, 8 failed

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':test'.
> There were failing tests. See the report at: file:///usr/local/google/home/drstrangelove/sdk-codegen/kotlin/build/reports/tests/test/index.html

* Try:
> Run with --scan to get full insights.

BUILD FAILED in 3s
Running git add -u ...
Running git commit -m "feat: generate SDKs for Looker 24.0" -m "Release-As: 24.0.0" ...
grep: warning: stray \ before -
grep: warning: stray \ before -
Running git push origin sdk_24_0 ...
remote: 
remote: Create a pull request for 'sdk_24_0' on GitHub by visiting:        
remote:      https://github.com/looker-open-source/sdk-codegen/pull/new/sdk_24_0        
remote: 
remote: GitHub found 11 vulnerabilities on looker-open-source/sdk-codegen's default branch (5 high, 6 moderate). To find out more, visit:        
remote:      https://github.com/looker-open-source/sdk-codegen/security/dependabot         
remote: 
To github.com:looker-open-source/sdk-codegen.git
 * [new branch]        sdk_24_0 -> sdk_24_0

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@drstrangelooker
Copy link
Collaborator Author

Trying

$ npm run lint:es

> sdk-codegen-all@23.21.0 lint:es
> eslint 'packages/**/*.ts{,x}' --cache

It is running for a very long time, might be hanging.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Feb 1, 2024

Go Tests

    6 files      6 suites   5m 17s ⏱️
  50 tests   50 ✔️ 0 💤 0 ❌
120 runs  120 ✔️ 0 💤 0 ❌

Results for commit ae3b03a.

Copy link
Contributor

github-actions bot commented Feb 1, 2024

Python Tests

    9 files      9 suites   1m 50s ⏱️
144 tests 139 ✔️   5 💤 0 ❌
676 runs  657 ✔️ 19 💤 0 ❌

Results for commit ae3b03a.

Copy link
Contributor

github-actions bot commented Feb 1, 2024

Typescript Tests

  10 files    64 suites   7m 42s ⏱️
227 tests 223 ✔️   4 💤 0 ❌
656 runs  624 ✔️ 32 💤 0 ❌

Results for commit ae3b03a.

Copy link
Collaborator

@jeremytchang jeremytchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drstrangelooker drstrangelooker merged commit 8c42be7 into main Feb 1, 2024
44 checks passed
@drstrangelooker drstrangelooker deleted the sdk_24_0 branch February 1, 2024 22:11

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

jeremytchang pushed a commit that referenced this pull request Feb 3, 2024
🤖 I have created a release *beep* *boop*
---


<details><summary>@looker/api-explorer: 0.9.56</summary>

### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @looker/extension-utils bumped from 0.1.32 to 0.1.33
    * @looker/run-it bumped from 0.9.55 to 0.9.56
    * @looker/sdk bumped from 23.20.1 to 24.0.0
  * devDependencies
    * @looker/sdk-codegen-scripts bumped from 21.5.12 to 21.5.13
    * @looker/sdk-node bumped from 23.20.1 to 24.0.0
</details>

<details><summary>@looker/extension-api-explorer: 22.21.13</summary>

### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @looker/api-explorer bumped from 0.9.55 to 0.9.56
    * @looker/extension-sdk bumped from 23.20.1 to 24.0.0
    * @looker/extension-sdk-react bumped from 23.20.1 to 24.0.0
    * @looker/extension-utils bumped from 0.1.32 to 0.1.33
    * @looker/run-it bumped from 0.9.55 to 0.9.56
    * @looker/sdk bumped from 23.20.1 to 24.0.0
</details>

<details><summary>@looker/extension-playground: 1.0.13</summary>

### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @looker/extension-sdk bumped from 23.20.1 to 24.0.0
    * @looker/extension-sdk-react bumped from 23.20.1 to 24.0.0
    * @looker/sdk bumped from 23.20.1 to 24.0.0
</details>

<details><summary>extension-tile-playground: 1.1.0</summary>

##
[1.1.0](extension-tile-playground-v1.0.0...extension-tile-playground-v1.1.0)
(2024-02-03)


### Features

* Allow for setting vis config in extensions
([3fbe8fd](3fbe8fd))
* Allow for setting vis config in extensions
([#1394](#1394))
([3ea3cfc](3ea3cfc))


### Bug Fixes

* sync up package versions
([#1356](#1356))
([351a15d](351a15d))


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @looker/extension-sdk bumped from 23.20.1 to 24.0.0
    * @looker/extension-sdk-react bumped from 23.20.1 to 24.0.0
    * @looker/sdk bumped from 23.20.1 to 24.0.0
</details>

<details><summary>@looker/extension-utils: 0.1.33</summary>

### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @looker/extension-sdk bumped from 23.20.1 to 24.0.0
    * @looker/extension-sdk-react bumped from 23.20.1 to 24.0.0
    * @looker/sdk bumped from 23.20.1 to 24.0.0
</details>

<details><summary>@looker/hackathon: 22.21.15</summary>

### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @looker/extension-sdk bumped from 23.20.1 to 24.0.0
    * @looker/extension-sdk-react bumped from 23.20.1 to 24.0.0
    * @looker/extension-utils bumped from 0.1.32 to 0.1.33
    * @looker/sdk bumped from 23.20.1 to 24.0.0
    * @looker/wholly-artifact bumped from 0.1.13 to 0.1.14
</details>

<details><summary>@looker/run-it: 0.9.56</summary>

### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @looker/extension-utils bumped from 0.1.32 to 0.1.33
    * @looker/sdk bumped from 23.20.1 to 24.0.0
</details>

<details><summary>@looker/sdk-codegen-scripts: 21.5.13</summary>

### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @looker/sdk bumped from 23.20.1 to 24.0.0
    * @looker/sdk-node bumped from 23.20.1 to 24.0.0
</details>

<details><summary>@looker/wholly-artifact: 0.1.14</summary>

### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @looker/sdk bumped from 23.20.1 to 24.0.0
  * devDependencies
    * @looker/sdk-node bumped from 23.20.1 to 24.0.0
</details>

<details><summary>@looker/wholly-sheet: 0.5.52</summary>

### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @looker/sdk bumped from 23.20.1 to 24.0.0
  * devDependencies
    * @looker/sdk-node bumped from 23.20.1 to 24.0.0
</details>

<details><summary>sdk-codegen-all: 24.0.0</summary>

##
[24.0.0](sdk-codegen-all-v23.21.0...sdk-codegen-all-v24.0.0)
(2024-02-03)


### Features

* generate SDKs for Looker 24.0
([#1426](#1426))
([8c42be7](8c42be7))


### Bug Fixes

* **Transport:** Disable automatic User Agent Suffix [clone of
[#1420](#1420)]
([#1423](#1423))
([aa6c173](aa6c173))
</details>

<details><summary>looker_sdk: 24.0.0</summary>

##
[24.0.0](looker_sdk-v23.20.1...looker_sdk-v24.0.0)
(2024-02-03)


### Features

* generate SDKs for Looker 24.0
([#1426](#1426))
([8c42be7](8c42be7))
</details>

<details><summary>embed-components: 24.0.0</summary>

##
[24.0.0](embed-components-v23.20.1...embed-components-v24.0.0)
(2024-02-03)


### Miscellaneous Chores

* **embed-components:** Synchronize undefined versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @looker/embed-services bumped from 23.20.1 to 24.0.0
    * @looker/sdk bumped from 23.20.1 to 24.0.0
  * devDependencies
    * @looker/sdk-node bumped from 23.20.1 to 24.0.0
</details>

<details><summary>embed-services: 24.0.0</summary>

##
[24.0.0](embed-services-v23.20.1...embed-services-v24.0.0)
(2024-02-03)


### Miscellaneous Chores

* **embed-services:** Synchronize undefined versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @looker/sdk bumped from 23.20.1 to 24.0.0
  * devDependencies
    * @looker/sdk-node bumped from 23.20.1 to 24.0.0
</details>

<details><summary>extension-sdk: 24.0.0</summary>

##
[24.0.0](extension-sdk-v23.20.1...extension-sdk-v24.0.0)
(2024-02-03)


### Miscellaneous Chores

* **extension-sdk:** Synchronize undefined versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @looker/sdk bumped from 23.20.1 to 24.0.0
</details>

<details><summary>extension-sdk-react: 24.0.0</summary>

##
[24.0.0](extension-sdk-react-v23.20.1...extension-sdk-react-v24.0.0)
(2024-02-03)


### Miscellaneous Chores

* **extension-sdk-react:** Synchronize undefined versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @looker/extension-sdk bumped from 23.20.1 to 24.0.0
    * @looker/sdk bumped from 23.20.1 to 24.0.0
</details>

<details><summary>sdk: 24.0.0</summary>

##
[24.0.0](sdk-v23.20.1...sdk-v24.0.0)
(2024-02-03)


### Features

* generate SDKs for Looker 24.0
([#1426](#1426))
([8c42be7](8c42be7))
</details>

<details><summary>sdk-node: 24.0.0</summary>

##
[24.0.0](sdk-node-v23.20.1...sdk-node-v24.0.0)
(2024-02-03)


### Miscellaneous Chores

* **sdk-node:** Synchronize undefined versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @looker/sdk bumped from 23.20.1 to 24.0.0
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants