Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update node version to 18 in package.json #1427

Merged
merged 1 commit into from
Feb 23, 2024
Merged

Conversation

jeremytchang
Copy link
Collaborator

Since we're now on node 18 in our CI and dependencies.

@jeremytchang jeremytchang changed the title Update node version to 18 in package.json chore: Update node version to 18 in package.json Feb 1, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@jeremytchang jeremytchang requested a review from a team as a code owner February 21, 2024 21:09
Copy link
Collaborator

@drstrangelooker drstrangelooker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks LGTM To Me

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

Codegen Tests

    1 files    18 suites   48s ⏱️
418 tests 400 ✔️ 18 💤 0 ❌

Results for commit 713f940.

Copy link
Contributor

APIX Tests

    1 files    89 suites   7m 13s ⏱️
426 tests 394 ✔️ 32 💤 0 ❌
448 runs  416 ✔️ 32 💤 0 ❌

Results for commit 713f940.

Copy link
Contributor

Typescript Tests

  10 files    64 suites   7m 18s ⏱️
227 tests 223 ✔️   4 💤 0 ❌
656 runs  624 ✔️ 32 💤 0 ❌

Results for commit 713f940.

@jeremytchang jeremytchang merged commit a2ff13b into main Feb 23, 2024
29 checks passed
@jeremytchang jeremytchang deleted the update_node branch February 23, 2024 02:17

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants