-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: generate SDKs for Looker 24.4 #1442
Conversation
Release-As: 24.4.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this passes CI it's fine for us but I'm concerned about the breaking change in the API
/// <summary>Json query results (read-only)</summary> | ||
public string[] data { get; set; } = null; | ||
public string[] rows { get; set; } = null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kenvlooker do we have documentation about this breaking API change?
Go Tests 6 files 6 suites 4m 39s ⏱️ Results for commit 6ab1c38. |
Typescript Tests 10 files 64 suites 6m 59s ⏱️ Results for commit 6ab1c38. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This reverts commit a05b8df.
Release-As: 24.4.0