Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kotlin: make Transport class open for extension to allow custom HTTP Transports #1519

Conversation

chizhang-g
Copy link
Collaborator

👋👋 Thank you for contributing to Looker sdk-codegen (⚡️🍣)

  • 👆 Make sure your pull request title follows Pull Request Title Guidelines from our Contribution guide
  • 👉 Don't forget to replace these instructions with your ✨awesome✨ description of what this change actually does. Additionally, it's great to include context on how it works and why the change was needed.
  • 👇 Edit "Developer Checklist" to reflect items relevant to this PR (and try to make sure to check everything off before asking for review)

Developer Checklist ℹ️

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Appropriate docs were updated (if necessary)

Fixes #1380 🦕

@chizhang-g chizhang-g requested a review from a team as a code owner October 11, 2024 15:44
@drstrangelooker drstrangelooker changed the base branch from main to Kotlin-support-custom-transport October 11, 2024 16:03
@drstrangelooker drstrangelooker merged commit 1c56a4c into looker-open-source:Kotlin-support-custom-transport Oct 11, 2024
1 of 2 checks passed
drstrangelooker added a commit that referenced this pull request Oct 22, 2024
#1520)

… HTTP Transports (#1519)

Fixes #1380 🦕

Copy of #1519

Co-authored-by: chizhang-g <chizhangcz@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kotlin: Allow pluggable HTTP clients
2 participants