Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix bad python package exclude #1521

Merged
merged 1 commit into from
Oct 21, 2024
Merged

fix: Fix bad python package exclude #1521

merged 1 commit into from
Oct 21, 2024

Conversation

jeremytchang
Copy link
Collaborator

@jeremytchang jeremytchang commented Oct 16, 2024 •
edited
Loading

The original exclude only included the looker_sdk folder. Afaict based off other examples, we should be using exclude.

Confirmed this fixes #1518 locally.

@jeremytchang
fix: Fix bad python package exclude
d02eb62 
The original exclude instead only included the `looker_sdk` folder.
Afaict based off other examples, we should be using exclude.
@jeremytchang jeremytchang requested a review from a team as a code owner October 16, 2024 17:12
drstrangelooker
drstrangelooker approved these changes Oct 16, 2024
View reviewed changes
Copy link
Collaborator

@drstrangelooker drstrangelooker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks LGTM To Me

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 16, 2024 •
edited
Loading

Python Tests

  9 files  + 1    9 suites  +1   1m 15s ⏱️ +17s
144 tests ± 0  136 ✅  -  3   5 💤 ±0  3 ❌ +3 
676 runs  +24  654 ✅ +20  19 💤 +1  3 ❌ +3 

For more details on these failures, see this check.

Results for commit d02eb62. ± Comparison against base commit 87b0976.

♻️ This comment has been updated with latest results.

@jeremytchang jeremytchang mentioned this pull request Oct 16, 2024
Closed
@drstrangelooker
Copy link
Collaborator

I have an open bug for the Looker error that is causing the tests to fail. I'm going to force this without waiting for Looker to be fixed.

@drstrangelooker drstrangelooker merged commit 5afd34b into main Oct 21, 2024
22 of 24 checks passed
@drstrangelooker drstrangelooker deleted the fix_py_setup branch October 21, 2024 14:17
Merged
drstrangelooker pushed a commit that referenced this pull request Oct 21, 2024
@looker-open-source-automation-bot
chore: release main (#1522)
5e46100 
🤖 I have created a release *beep* *boop*
---


<details><summary>@looker/api-explorer: 0.9.69</summary>

### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @looker/code-editor bumped from 0.1.35 to 0.1.36
    * @looker/extension-utils bumped from 0.1.45 to 0.1.46
    * @looker/run-it bumped from 0.9.68 to 0.9.69
    * @looker/sdk bumped from 24.18.0 to 24.18.1
    * @looker/sdk-codegen bumped from 21.9.4 to 21.9.5
  * devDependencies
    * @looker/sdk-codegen-scripts bumped from 21.5.25 to 21.5.26
    * @looker/sdk-node bumped from 24.18.0 to 24.18.1
</details>

<details><summary>@looker/code-editor: 0.1.36</summary>

### Dependencies

* The following workspace dependencies were updated
  * devDependencies
    * @looker/sdk-codegen bumped from 21.9.4 to 21.9.5
</details>

<details><summary>@looker/extension-api-explorer: 22.21.26</summary>

### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @looker/api-explorer bumped from 0.9.68 to 0.9.69
    * @looker/extension-sdk bumped from 24.18.0 to 24.18.1
    * @looker/extension-sdk-react bumped from 24.18.0 to 24.18.1
    * @looker/extension-utils bumped from 0.1.45 to 0.1.46
    * @looker/run-it bumped from 0.9.68 to 0.9.69
    * @looker/sdk bumped from 24.18.0 to 24.18.1
    * @looker/sdk-codegen bumped from 21.9.4 to 21.9.5
</details>

<details><summary>@looker/extension-playground: 1.0.26</summary>

### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @looker/extension-sdk bumped from 24.18.0 to 24.18.1
    * @looker/extension-sdk-react bumped from 24.18.0 to 24.18.1
    * @looker/sdk bumped from 24.18.0 to 24.18.1
</details>

<details><summary>@looker/extension-tile-playground: 1.1.13</summary>

### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @looker/extension-sdk bumped from 24.18.0 to 24.18.1
    * @looker/extension-sdk-react bumped from 24.18.0 to 24.18.1
    * @looker/sdk bumped from 24.18.0 to 24.18.1
</details>

<details><summary>@looker/extension-utils: 0.1.46</summary>

### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @looker/code-editor bumped from 0.1.35 to 0.1.36
    * @looker/extension-sdk bumped from 24.18.0 to 24.18.1
    * @looker/extension-sdk-react bumped from 24.18.0 to 24.18.1
    * @looker/sdk bumped from 24.18.0 to 24.18.1
</details>

<details><summary>@looker/hackathon: 22.21.28</summary>

### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @looker/code-editor bumped from 0.1.35 to 0.1.36
    * @looker/extension-sdk bumped from 24.18.0 to 24.18.1
    * @looker/extension-sdk-react bumped from 24.18.0 to 24.18.1
    * @looker/extension-utils bumped from 0.1.45 to 0.1.46
    * @looker/sdk bumped from 24.18.0 to 24.18.1
    * @looker/wholly-artifact bumped from 0.1.26 to 0.1.27
</details>

<details><summary>@looker/run-it: 0.9.69</summary>

### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @looker/code-editor bumped from 0.1.35 to 0.1.36
    * @looker/extension-utils bumped from 0.1.45 to 0.1.46
    * @looker/sdk bumped from 24.18.0 to 24.18.1
    * @looker/sdk-codegen bumped from 21.9.4 to 21.9.5
    * @looker/sdk-codegen-utils bumped from 21.0.15 to 21.0.16
</details>

<details><summary>@looker/sdk-codegen: 21.9.5</summary>

### Dependencies

* The following workspace dependencies were updated
  * devDependencies
    * @looker/sdk-codegen-utils bumped from 21.0.15 to 21.0.16
</details>

<details><summary>@looker/sdk-codegen-scripts: 21.5.26</summary>

### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @looker/sdk bumped from 24.18.0 to 24.18.1
    * @looker/sdk-codegen bumped from 21.9.4 to 21.9.5
    * @looker/sdk-codegen-utils bumped from 21.0.15 to 21.0.16
    * @looker/sdk-node bumped from 24.18.0 to 24.18.1
</details>

<details><summary>@looker/sdk-codegen-utils: 21.0.16</summary>

### Dependencies

* The following workspace dependencies were updated
  * devDependencies
    * @looker/sdk bumped from 24.18.0 to 24.18.1
    * @looker/sdk-node bumped from 24.18.0 to 24.18.1
</details>

<details><summary>@looker/wholly-artifact: 0.1.27</summary>

### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @looker/sdk bumped from 24.18.0 to 24.18.1
  * devDependencies
    * @looker/sdk-node bumped from 24.18.0 to 24.18.1
</details>

<details><summary>@looker/wholly-sheet: 0.5.65</summary>

### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @looker/sdk bumped from 24.18.0 to 24.18.1
  * devDependencies
    * @looker/sdk-node bumped from 24.18.0 to 24.18.1
</details>

<details><summary>sdk-codegen-all: 24.18.1</summary>

##
[24.18.1](sdk-codegen-all-v24.18.0...sdk-codegen-all-v24.18.1)
(2024-10-21)


### Bug Fixes

* Fix bad python package exclude
([#1521](#1521))
([5afd34b](5afd34b))
</details>

<details><summary>looker_sdk: 24.18.1</summary>

##
[24.18.1](looker_sdk-v24.18.0...looker_sdk-v24.18.1)
(2024-10-21)


### Bug Fixes

* Fix bad python package exclude
([#1521](#1521))
([5afd34b](5afd34b))
</details>

<details><summary>embed-components: 24.18.1</summary>

##
[24.18.1](embed-components-v24.18.0...embed-components-v24.18.1)
(2024-10-21)


### Miscellaneous Chores

* **embed-components:** Synchronize undefined versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @looker/embed-services bumped from 24.18.0 to 24.18.1
    * @looker/sdk bumped from 24.18.0 to 24.18.1
  * devDependencies
    * @looker/sdk-node bumped from 24.18.0 to 24.18.1
</details>

<details><summary>embed-services: 24.18.1</summary>

##
[24.18.1](embed-services-v24.18.0...embed-services-v24.18.1)
(2024-10-21)


### Miscellaneous Chores

* **embed-services:** Synchronize undefined versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @looker/sdk bumped from 24.18.0 to 24.18.1
  * devDependencies
    * @looker/sdk-node bumped from 24.18.0 to 24.18.1
</details>

<details><summary>extension-sdk: 24.18.1</summary>

##
[24.18.1](extension-sdk-v24.18.0...extension-sdk-v24.18.1)
(2024-10-21)


### Miscellaneous Chores

* **extension-sdk:** Synchronize undefined versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @looker/sdk bumped from 24.18.0 to 24.18.1
</details>

<details><summary>extension-sdk-react: 24.18.1</summary>

##
[24.18.1](extension-sdk-react-v24.18.0...extension-sdk-react-v24.18.1)
(2024-10-21)


### Miscellaneous Chores

* **extension-sdk-react:** Synchronize undefined versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @looker/extension-sdk bumped from 24.18.0 to 24.18.1
    * @looker/sdk bumped from 24.18.0 to 24.18.1
</details>

<details><summary>sdk: 24.18.1</summary>

##
[24.18.1](sdk-v24.18.0...sdk-v24.18.1)
(2024-10-21)


### Miscellaneous Chores

* **sdk:** Synchronize undefined versions
</details>

<details><summary>sdk-node: 24.18.1</summary>

##
[24.18.1](sdk-node-v24.18.0...sdk-node-v24.18.1)
(2024-10-21)


### Miscellaneous Chores

* **sdk-node:** Synchronize undefined versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @looker/sdk bumped from 24.18.0 to 24.18.1
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drstrangelooker drstrangelooker drstrangelooker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Python SDK v24.18.0 can't import looker_sdk
2 participants
@jeremytchang @drstrangelooker