Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove reference to react in extension-sdk #1532

Merged
merged 3 commits into from
Oct 28, 2024
Merged

fix: remove reference to react in extension-sdk #1532

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8a4f91b
fix reference to react in extension-sdk
bryans99 Oct 28, 2024
af86675
Merge branch 'main' into fix-typescript
jkaster Oct 28, 2024
44d5c6f
Merge branch 'main' into fix-typescript
drstrangelooker Oct 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/extension-sdk/src/connect/tile/tile_sdk.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
*/

import type { MouseEvent } from 'react';
import { NOT_DASHBOARD_MOUNT_NOT_SUPPORTED_ERROR } from '../../util/errors';
import { ExtensionRequestType } from '../types';
import type { ExtensionHostApiImpl } from '../extension_host_api';
Expand Down
1 change: 0 additions & 1 deletion packages/extension-sdk/src/connect/tile/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
*/

import type { MouseEvent } from 'react';
import type { IQuery } from '@looker/sdk';

/**
Expand Down
12 changes: 7 additions & 5 deletions ...extension-tile-playground/src/components/Inspector/components/EventTester/EventTester.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@

*/
import React, { useCallback, useContext, useState } from 'react';
import type { MouseEvent } from 'react';
import {
Accordion2,
ButtonOutline,
Expand Down Expand Up @@ -58,17 +57,20 @@ export const EventTester: React.FC = () => {
}, [tileSDK]);

const toggleCrossFilterClick = useCallback(
(event: MouseEvent) => {
(event: React.MouseEvent<HTMLButtonElement>) => {
// TODO pivot and row data needs to be populated
tileSDK.toggleCrossFilter({ pivot: {} as any, row: {} as any }, event);
tileSDK.toggleCrossFilter(
{ pivot: {} as any, row: {} as any },
event as unknown as MouseEvent
);
},
[tileSDK]
);

const openDrillMenuClick = useCallback(
(event: MouseEvent) => {
(event: React.MouseEvent<HTMLButtonElement>) => {
// TODO links data needs to be populated
tileSDK.openDrillMenu({ links: [] }, event);
tileSDK.openDrillMenu({ links: [] }, event as unknown as MouseEvent);
},
[tileSDK]
);
Expand Down
Loading