fix: Improve ok() helper function #1542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Eliminate duplicated version in AuthSession by delegating to a shared implementation defined on the SDKResponse companion object. - For the SDKError case: - Set Error.message from SDKError.message - Set Error.casue from SDKError.cause
haywood
force-pushed
the
haywood-improve-ok
branch
6 times, most recently
from
897905d to
608e1b5
Compare
haywood
force-pushed
the
haywood-improve-ok
branch
2 times, most recently
from
ad3f8e1 to
82c583b
Compare
haywood
force-pushed
the
haywood-improve-ok
branch
from
82c583b to
af708e2
Compare
drstrangelooker
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm hesitant to change this function too much, since we don't know what kind of odd dependencies on its current behavior might exist. However, adding exception chaining and surfacing the original error message seems like a risk worth taking.
Eliminate duplicated version in AuthSession by delegating to a shared implementation defined on the SDKResponse companion object.
For the SDKError case:
Also ran
ktlint -Fon the files I changed so thatgradle checkwould pass the linting stageAlso added kotlin-ci.yml to run
./gradlew jaron kotlin changesFixes #1539 🦕