-
Notifications
You must be signed in to change notification settings - Fork 42
hackathon app: localize #38
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good so far. I don't see the english strings file though. We should also discuss with @dthorpe and Andrew whether this is the correct localization architecture to use for this
Wondering what that browser locale discovery thing uses to select locale |
Hi @josephaxisa sorry for the delay... |
Thanks @mdodgelooker, I have been planning to get that fixed. I wanted to see if the approach I took was architecturally sound more than anything. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@josephaxisa as a start it looks good architecturally to me (lens is planning to use i18next
as well) – once you add the English strings and fix the un-localized string, should be GTG!
No description provided.