Multichain Precision Adjustment Support #460
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enlight
reviewed
Oct 30, 2019
| @@ -40,6 +40,8 @@ message AddressMapperGetMappingRequest { | |||
| message AddressMapperGetMappingResponse { | |||
| Address from = 1; // Address that was provided in the request | |||
| Address to = 2; | |||
| uint32 from_decimals = 3; | |||
| uint32 to_decimals = 4; | |||
There was a problem hiding this comment.
I don't understand why these fields were added here.
There was a problem hiding this comment.
Planed to use it for command line. But I think can just remove it for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds decimals fields to address mapper and transfer gateway contract types.