Avoid self-crossing of involute teeth #136
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At extreme pressure angles (e.g. 45 degrees), the line defining the gear surface would have self-crossings at tooth tips and bases before this fix. The curve defined by involute_points was leaving the angular range (0 to self.phipart / 2) allowed for the half of the tooth.
|
Thanks, for the contribution. I guess this should not depend on numpoints. Maybe you can calculate the value for the intersection. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At extreme pressure angles (e.g. 45 degrees), the line defining the gear surface would have self-crossings at tooth tips and bases before this fix. The curve defined by involute_points was leaving the angular range (0 to self.phipart / 2) allowed for the half of the tooth.
This screenshot demonstrates the problem. This is the default involute gear that gets created from the workbench, except with the pressure angle changes to 45 degrees and numpoints turned up to 10.