Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename GUI commands to follow FreeCAD format #153

Merged
merged 2 commits into from
Oct 5, 2024

Conversation

hasecilu
Copy link
Contributor

@hasecilu hasecilu commented Feb 15, 2024

  • Making this change will enable users to use What's this? command on FCGear commands and get the correct Wiki article opened.
  • Add missing comma that provoked error.

I make the test saving a file prior the change and opening after it, no problems, anyway someone test it. Since no changes on the names of classes that create the objects were made I think is safe to merge.

Fix #151, #154

Making this change will enable users to use `What's this?` command on FCGear
commands and get the correct Wiki article.

Fix looooo#151
@looooo
Copy link
Owner

looooo commented Feb 16, 2024

Can we change the workbench name to freecad.gears, maybe doing this also for the wiki.

@hasecilu
Copy link
Contributor Author

I think it's doable, but just admins can do it.
Regarding the capitalization, to make it "fit" to the other pages what do you think about FreeCADGears for the workbench and commands would be like FreeCADGears_InvoluteGear?

@looooo
Copy link
Owner

looooo commented Feb 28, 2024

is this backward compatible?

@hasecilu
Copy link
Contributor Author

hasecilu commented Feb 29, 2024

Edit 2024-09-10:

is this backward compatible?

Yes, because the classes that create the objects are not changed there is no problems


I made some test files before the renaming and opening them after the change seems to not affect them. As long as no properties are modified it's safe renaming commands. Even for scripting the Create* classes are used directly the toolbar commands are not involved.

@hasecilu hasecilu mentioned this pull request Mar 10, 2024
@hasecilu
Copy link
Contributor Author

hasecilu commented Mar 10, 2024

I have just made this same changes for Fasteners WB and all seems to work fine there also.
Do you prefer FreeCADGears_ instead of FCGear_?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

What's this? command opens wrong wiki article url
2 participants