Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lb4 controller fails with type BASIC #10494

Open
aaqilniz opened this issue May 3, 2024 · 2 comments · May be fixed by #10624
Open

lb4 controller fails with type BASIC #10494

aaqilniz opened this issue May 3, 2024 · 2 comments · May be fixed by #10624
Assignees
@major-winter
Labels
bug

Comments

@aaqilniz
Copy link
Contributor

aaqilniz commented May 3, 2024

Describe the bug

Running lb4 controller --controllerType="BASIC" --name=first-controller-ever fails with the following error:

Generation is aborted: No models found

This means the command is trying to find models - which only happens when the controller type is REST.

Logs

No change to package.json was detected. No package manager install will be executed.
Generation is aborted: No models found in /home/.../sample-app/src/models. Please visit http://loopback.io/doc/en/lb4/Controller-generator.html for information on how models are discovered.

Additional information

No response

Reproduction

Any basic loopback application
@aaqilniz aaqilniz added the bug label May 3, 2024
@major-winter
Copy link

Please assign it to me! I'm interested in this. This would be my first ever contribution to an open source project.

@dhmlau
Copy link
Member

dhmlau commented Aug 3, 2024

@major-winter, assigned! Thank you.

major-winter added a commit to major-winter/loopback-next that referenced this issue Aug 4, 2024
@major-winter
fix: fix CLI execution with explicit --controllerType=BASIC option
7aa76a7 
fix loopbackio#10494

Signed-off-by: TC <tuanchuhoang@gmail.com>
@major-winter major-winter linked a pull request Aug 4, 2024 that will close this issue
Open
8 tasks
major-winter added a commit to major-winter/loopback-next that referenced this issue Aug 20, 2024
@major-winter
fix: fix CLI execution with explicit --controllerType=BASIC option
500e20b 
fix loopbackio#10494

Signed-off-by: TC <tuanchuhoang@gmail.com>
major-winter added a commit to major-winter/loopback-next that referenced this issue Aug 26, 2024
@major-winter
fix: loopbackio#10494 - lb4 controller fails with controllerType as B…
c50e1df 
…ASIC

- fix CLI execution with explicit --controllerType=BASIC option
- add a unit test that verifies the scaffold when explicity specifying the controller type as BASIC

Signed-off-by: TC <tuanchuhoang@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@major-winter major-winter

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: fix CLI execution with explicit --controllerType=BASIC option major-winter/loopback-next
3 participants
@dhmlau @aaqilniz @major-winter