fix: fix CLI execution with explicit --controllerType=BASIC option #10624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @major-winter. Can you please add some tests around your change? The changes looks good to me. |
aaqilniz
requested changes
Aug 20, 2024
major-winter
force-pushed
the
fix/#10494_lb4_controller_fails_with_type_BASIC
branch
2 times, most recently
from
458ddc1
to
bb42e57
Compare
|
Hi @aaqilniz , I've undone as suggested. Please review the PR again. Thank you for your support. |
|
Hi, @major-winter. Please squash the commits. Everything else seems good. |
…ASIC - fix CLI execution with explicit --controllerType=BASIC option - add a unit test that verifies the scaffold when explicity specifying the controller type as BASIC Signed-off-by: TC <tuanchuhoang@gmail.com>
major-winter
force-pushed
the
fix/#10494_lb4_controller_fails_with_type_BASIC
branch
from
bb42e57
to
c50e1df
Compare
|
Hi @aaqilniz, I've squashed my commits into 1. Please review it when you have time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #10494
Fix controller failure when --controllerType=BASIC is explicitly specified
Checklist
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated👉 Check out how to submit a PR 👈