Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: build method parameters while generating controller #10579

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aaqilniz
Copy link
Contributor

@aaqilniz aaqilniz commented Jun 20, 2024

With my PR here, I enabled the openapi generator to create the controller. That implementation has a bug that ultimately generates buggy controller code in case there is a method parameter with a hyphen (e.g. access-token).

This PR fixes that by properly building the parameter.

Checklist

  • DCO (Developer Certificate of Origin) signed in all commits
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

👉 Check out how to submit a PR 👈

@coveralls
Copy link

coveralls commented Jun 20, 2024

Pull Request Test Coverage Report for Build 9597053115

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 54.772%

Totals Coverage Status
Change from base Build 9587353604: 0.0%
Covered Lines: 9566
Relevant Lines: 12465

💛 - Coveralls

@aaqilniz aaqilniz changed the title fix: add quotes to param names containing hyphens fix: build method parameters while generating services Aug 24, 2024
@aaqilniz aaqilniz changed the title fix: build method parameters while generating services fix: build method parameters while generating controller Aug 24, 2024
Signed-off-by: Muhammad Aaqil <aaqilcs102@gmail.com>
@aaqilniz aaqilniz marked this pull request as ready for review August 25, 2024 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants