Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: added new parameter to control the xml parsing #687

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Apkovy
Copy link

@Apkovy Apkovy commented Feb 2, 2024

Description

New parameter "trimText" in XMLHandler constructor, which is used in p.ontext method to allow or prevent trimming the text value.

Related issues

#610

Added new boolean parameter "textTrim" to options object in XMLHandler constructor. This new parameter is used in p.ontext method. The default value is true for backward compatibility.

Signed-off-by: Apkovy <86667438+Apkovy@users.noreply.github.com>
Signed-off-by: Apkovy <86667438+Apkovy@users.noreply.github.com>
Only one missing star in param comment. No fix, no functionality change.

Signed-off-by: Apkovy <86667438+Apkovy@users.noreply.github.com>
@dhmlau
Copy link
Member

dhmlau commented Feb 4, 2024

@Apkovy, thanks for the PR. Could you please add tests around your changes? Thanks.

@dhmlau
Copy link
Member

dhmlau commented Feb 12, 2024

@Apkovy, thanks for your contribution. Your changes look reasonable to me. Could you please add tests for the changes? Thanks.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7759625940

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 84.636%

Totals Coverage Status
Change from base Build 7746226260: -0.02%
Covered Lines: 2894
Relevant Lines: 3249

💛 - Coveralls

Signed-off-by: Apkovy <86667438+Apkovy@users.noreply.github.com>
@Apkovy
Copy link
Author

Apkovy commented Mar 11, 2024

@dhmlau Thank you. I created the tests and all jobs passed in the run for the branch trim-text.

Am I supposed to do anything else?

@dhmlau
Copy link
Member

dhmlau commented Apr 4, 2024

hm.. I don't think I see the tests added, but saw there's a new main.yml file which doesn't seem to be related to the change. Maybe there's some changes you haven't pushed yet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants