chore: added new parameter to control the xml parsing #687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added new boolean parameter "textTrim" to options object in XMLHandler constructor. This new parameter is used in p.ontext method. The default value is true for backward compatibility. Signed-off-by: Apkovy <86667438+Apkovy@users.noreply.github.com>
Signed-off-by: Apkovy <86667438+Apkovy@users.noreply.github.com>
Only one missing star in param comment. No fix, no functionality change. Signed-off-by: Apkovy <86667438+Apkovy@users.noreply.github.com>
|
@Apkovy, thanks for the PR. Could you please add tests around your changes? Thanks. |
|
@Apkovy, thanks for your contribution. Your changes look reasonable to me. Could you please add tests for the changes? Thanks. |
Pull Request Test Coverage Report for Build 7759625940Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Signed-off-by: Apkovy <86667438+Apkovy@users.noreply.github.com>
|
@dhmlau Thank you. I created the tests and all jobs passed in the run for the branch trim-text. Am I supposed to do anything else? |
|
hm.. I don't think I see the tests added, but saw there's a new main.yml file which doesn't seem to be related to the change. Maybe there's some changes you haven't pushed yet? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New parameter "trimText" in XMLHandler constructor, which is used in p.ontext method to allow or prevent trimming the text value.
Related issues
#610