cmd: add --log-level CLI flag #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgfa29
force-pushed
the
add-log-level-flag
branch
from
193f9f6 to
9a36b0e
Compare
Allow specifying the log level directly as the global CLI flag `--log-level`. Signed-off-by: Luiz Aoqui <luizaoqui@loopholelabs.io>
lgfa29
force-pushed
the
add-log-level-flag
branch
from
9a36b0e to
9ff17c8
Compare
Signed-off-by: Luiz Aoqui <luizaoqui@loopholelabs.io>
Signed-off-by: Luiz Aoqui <luizaoqui@loopholelabs.io>
lgfa29
commented
Oct 16, 2024
pkg/command/testing.go
Outdated
Comment on lines
87
to
93
| // Common configuration values. | ||
| Format string | ||
| Debug bool | ||
| NoColor bool `mapstructure:"no-color"` | ||
|
|
||
| // Custom configuration values. | ||
| MyConfig string `mapstructure:"my-config"` |
There was a problem hiding this comment.
I was using these in a WIP set of config tests that I may push in the future, but they're not exactly necessary in this PR. I can remove them for now, but they also don't really affect anything.
There was a problem hiding this comment.
Format,Debug, NoColor are all fine, but MyConfig seems out of place and might confuse, so let's get rid of that for now.
There was a problem hiding this comment.
Yeah, sounds good. Removed in 570b233
Signed-off-by: Shivansh Vij <shivanshvij@loopholelabs.io>
Signed-off-by: Luiz Aoqui <luizaoqui@loopholelabs.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow specifying the log level directly as the global CLI flag
--log-level.Draft for now since it requires loopholelabs/logging#7 and loopholelabs/logging#8.Merged!