async: ensure connection close error is set #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous implementation had a couple of issues that could cause closeWithError() to not propagate the passed error properly. 1. c.error.Store() is only called after c.close(), which could cause the channel returned by CloseChannel() to be closed before the error is set. Callers that that block on the channel may attempt to read the error before it is set. 2. If c.close() fails, closeError is returned, but not set to c.error.Store(), causing callers to miss it. Additionally, the original error is ignored and not made available to callers at all. To fix these issues, closeWithError() is updated to set c.error before calling c.close() and all errors are returned and set to c.error by using errors.Join(). In order to support different kinds of concrete error types, the type of the error field had to be changed from atomic.Value to error. Signed-off-by: Luiz Aoqui <luizaoqui@loopholelabs.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation had a couple of issues that could cause closeWithError() to not propagate the passed error properly.
To fix these issues, closeWithError() is updated to set c.error before calling c.close() and all errors are returned and set to c.error by using errors.Join().
In order to support different kinds of concrete error types, the type of the error field had to be changed from atomic.Value to error.