Skip to content

Commit

Permalink
Merge pull request #108 from loopholelabs/fix-js-builder-windows-msvc
Browse files Browse the repository at this point in the history
Fix: JS Builder on Windows MSVC Not Working
  • Loading branch information
ShivanshVij authored Sep 20, 2023
2 parents 8b8146d + 320acf5 commit 5541bed
Show file tree
Hide file tree
Showing 37 changed files with 43 additions and 36 deletions.
9 changes: 8 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,12 @@ to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [Unreleased]

## [v0.4.1] - 2023-09-20

### Fixes

- Fixing a bug where the imported typescript builder was unable to find the generated builder CLI because it was called `js_builder-x86_64-pc-windows-msvc.exe` instead of `js_builder-x86_64-pc-windows-msvc`.

## [v0.4.0] - 2023-09-20

### Features
Expand Down Expand Up @@ -249,7 +255,8 @@ to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

- Initial release of the Scale Runtime library.

[unreleased]: https://github.com/loopholelabs/scale/compare/v0.4.0...HEAD
[unreleased]: https://github.com/loopholelabs/scale/compare/v0.4.1...HEAD
[v0.4.1]: https://github.com/loopholelabs/scale/compare/v0.4.1
[v0.4.0]: https://github.com/loopholelabs/scale/compare/v0.4.0
[v0.3.19]: https://github.com/loopholelabs/scale/compare/v0.3.19
[v0.3.18]: https://github.com/loopholelabs/scale/compare/v0.3.18
Expand Down
2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "scale_rs"
version = "0.4.0"
version = "0.4.1"
edition = "2021"
description = "Scale is a framework for building high-performance plugin systems into any application, all powered by WebAssembly."
homepage = "https://scale.sh"
Expand Down
2 changes: 1 addition & 1 deletion compile/typescript/builder/builder_x86_64-windows.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,5 +22,5 @@ import (
_ "embed"
)

//go:embed js_builder-x86_64-pc-windows-msvc
//go:embed js_builder-x86_64-pc-windows-msvc.exe
var BuilderExecutable []byte
Binary file modified compile/typescript/builder/js_builder-aarch64-unknown-linux-gnu
Binary file not shown.
2 changes: 1 addition & 1 deletion integration/golang_tests/generated/generated.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion integration/golang_tests/host_signature/host.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion integration/golang_tests/host_signature/types.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion integration/golang_tests/signature/guest.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion integration/golang_tests/signature/types.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion integration/rust_tests/generated/generated.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Code generated by scale-signature 0.4.0, DO NOT EDIT.
// Code generated by scale-signature 0.4.1, DO NOT EDIT.
// output: generated

#![allow(dead_code)]
Expand Down
2 changes: 1 addition & 1 deletion integration/rust_tests/signature/guest.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Code generated by scale-signature 0.4.0, DO NOT EDIT.
// Code generated by scale-signature 0.4.1, DO NOT EDIT.
// output: local_example_latest_guest

pub mod types;
Expand Down
2 changes: 1 addition & 1 deletion integration/rust_tests/signature/types.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Code generated by scale-signature 0.4.0, DO NOT EDIT.
// Code generated by scale-signature 0.4.1, DO NOT EDIT.
// output: local_example_latest_guest

#![allow(dead_code)]
Expand Down
2 changes: 1 addition & 1 deletion integration/typescript_tests/generated/generated.d.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Code generated by scale-signature 0.4.0, DO NOT EDIT.
// Code generated by scale-signature 0.4.1, DO NOT EDIT.
// output: generated

import { Encoder, Decoder, Kind } from "@loopholelabs/polyglot"
Expand Down
2 changes: 1 addition & 1 deletion integration/typescript_tests/generated/generated.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion integration/typescript_tests/generated/generated.js.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion integration/typescript_tests/host_signature/index.d.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Code generated by scale-signature 0.4.0, DO NOT EDIT.
// Code generated by scale-signature 0.4.1, DO NOT EDIT.
// output: local-example-latest-host

import { Signature as SignatureInterface } from "@loopholelabs/scale-signature-interfaces";
Expand Down
2 changes: 1 addition & 1 deletion integration/typescript_tests/host_signature/index.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion integration/typescript_tests/host_signature/index.js.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion integration/typescript_tests/host_signature/index.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Code generated by scale-signature 0.4.0, DO NOT EDIT.
// Code generated by scale-signature 0.4.1, DO NOT EDIT.
// output: local-example-latest-host

/* eslint no-bitwise: off */
Expand Down
2 changes: 1 addition & 1 deletion integration/typescript_tests/host_signature/types.d.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Code generated by scale-signature 0.4.0, DO NOT EDIT.
// Code generated by scale-signature 0.4.1, DO NOT EDIT.
// output: local-example-latest-host

import { Encoder, Decoder, Kind } from "@loopholelabs/polyglot"
Expand Down
2 changes: 1 addition & 1 deletion integration/typescript_tests/host_signature/types.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion integration/typescript_tests/host_signature/types.js.map

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion integration/typescript_tests/host_signature/types.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Code generated by scale-signature 0.4.0, DO NOT EDIT.
// Code generated by scale-signature 0.4.1, DO NOT EDIT.
// output: local-example-latest-host

import { Encoder, Decoder, Kind } from "@loopholelabs/polyglot"
Expand Down
2 changes: 1 addition & 1 deletion integration/typescript_tests/signature/index.d.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Code generated by scale-signature 0.4.0, DO NOT EDIT.
// Code generated by scale-signature 0.4.1, DO NOT EDIT.
// output: local-example-latest-guest

export * from "./types";
Expand Down
2 changes: 1 addition & 1 deletion integration/typescript_tests/signature/index.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 5541bed

Please sign in to comment.