Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jamesmoore/arch 161 silo add sync to newdevice config #39

Merged
merged 5 commits into from
Oct 24, 2024

Conversation

jimmyaxod
Copy link
Contributor

  • Added S3 Metrics to S3Storage.
  • Device can now optionally sync the device to S3.
  • The S3 sync can be controlled using Silo Storage Events.

@jimmyaxod jimmyaxod changed the base branch from main to jamesmoore/arch-144-create-a-sync-method-in-silo-to-handle-some-of-the-heavy October 23, 2024 18:06
Copy link
Member

@ShivanshVij ShivanshVij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, couple of questions

pkg/storage/device/device.go Outdated Show resolved Hide resolved
pkg/storage/sources/s3_storage.go Show resolved Hide resolved
pkg/storage/sources/s3_storage.go Outdated Show resolved Hide resolved
@jimmyaxod jimmyaxod force-pushed the jamesmoore/arch-144-create-a-sync-method-in-silo-to-handle-some-of-the-heavy branch 2 times, most recently from 8cca431 to b19e610 Compare October 24, 2024 09:48
Base automatically changed from jamesmoore/arch-144-create-a-sync-method-in-silo-to-handle-some-of-the-heavy to main October 24, 2024 10:08
@jimmyaxod jimmyaxod force-pushed the jamesmoore/arch-161-silo-add-sync-to-newdevice-config branch from fc0be19 to 3f913af Compare October 24, 2024 10:12
…age.

Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>
Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>
Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>
Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>
@jimmyaxod jimmyaxod force-pushed the jamesmoore/arch-161-silo-add-sync-to-newdevice-config branch from 822f0d1 to 85a59c3 Compare October 24, 2024 10:16
Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>
@jimmyaxod jimmyaxod merged commit 5a281a9 into main Oct 24, 2024
4 checks passed
@jimmyaxod jimmyaxod deleted the jamesmoore/arch-161-silo-add-sync-to-newdevice-config branch October 24, 2024 10:31
@github-actions github-actions bot locked and limited conversation to collaborators Oct 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants