-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jamesmoore/logging #49
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmyaxod
force-pushed
the
jamesmoore/logging
branch
3 times, most recently
from
November 4, 2024 22:46
31c0e5a
to
94c10be
Compare
jimmyaxod
force-pushed
the
jamesmoore/logging
branch
from
November 18, 2024 14:17
b4f8335
to
2de0325
Compare
jimmyaxod
changed the base branch from
main
to
jamesmoore/arch-211-add-logging-to-silo
November 18, 2024 14:22
jimmyaxod
force-pushed
the
jamesmoore/logging
branch
6 times, most recently
from
November 19, 2024 15:51
90dcf3c
to
8cf3f11
Compare
jimmyaxod
force-pushed
the
jamesmoore/arch-211-add-logging-to-silo
branch
from
November 19, 2024 17:22
b47ef36
to
306f127
Compare
Base automatically changed from
jamesmoore/arch-211-add-logging-to-silo
to
main
November 19, 2024 17:24
Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>
jimmyaxod
force-pushed
the
jamesmoore/logging
branch
from
November 19, 2024 17:50
8cf3f11
to
d504fe4
Compare
Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>
Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>
Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>
Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>
Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>
jimmyaxod
force-pushed
the
jamesmoore/logging
branch
from
November 19, 2024 20:11
d504fe4
to
5a7f3b5
Compare
jimmyaxod
changed the base branch from
main
to
jamesmoore/arch-212-silo-metrics
November 19, 2024 20:12
Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>
jimmyaxod
force-pushed
the
jamesmoore/logging
branch
from
November 19, 2024 20:20
5a7f3b5
to
a8f480e
Compare
Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>
Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>
Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io> Added logging to nbd, tidied up nbd config Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io> Added logging to device Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io> Added log for connect/serve commands Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io> storage logger now uses loopholelabs lib Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io> lint Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io> Updated with threadsafe bytes buffer for log in tests Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io> nbd dispatch returns fatal errors to caller Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io> Added optional logging to waiting cache. Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io> Added metrics to ProtocolRW and ToProtocol. Logged in cmd/serve Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io> lint fix Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io> Added metrics to waitingcache Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io> connect now logs protocol metrics at end Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io> Added metrics to FromProtocol and logs at end of cmd/connect Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io> Added metrics for nbd expose. Logged in cmd/serve Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io> Latest metrics Added metrics on dirtyTracker Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io> Added metrics to volatilitymonitor Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io> Added general provider metrics Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io> Added other toProtocol metris Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io> metrics tidy and new buffered writer Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io> Add buffered writer option delay timer Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io> RW can now use buffering Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io> Buffered writer working Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io> Fix Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io> nbd lock Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io> Added nbd and waitingcache metrics Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io> Removed buffered write and rebase to new log pr Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io> Removed write buffer bits Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>
jimmyaxod
force-pushed
the
jamesmoore/logging
branch
from
November 19, 2024 20:50
a8f480e
to
6f3a822
Compare
jimmyaxod
force-pushed
the
jamesmoore/arch-212-silo-metrics
branch
from
November 20, 2024 17:30
352be07
to
fda813a
Compare
Done in arch-211-add-logging-to-silo and #55 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added optional logging to Migrator, NBD, Device, and Sync bits