Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jamesmoore/logging #49

Closed
wants to merge 11 commits into from

Conversation

jimmyaxod
Copy link
Contributor

Added optional logging to Migrator, NBD, Device, and Sync bits

@jimmyaxod jimmyaxod force-pushed the jamesmoore/logging branch 3 times, most recently from 31c0e5a to 94c10be Compare November 4, 2024 22:46
@jimmyaxod jimmyaxod marked this pull request as draft November 5, 2024 18:03
@jimmyaxod jimmyaxod changed the base branch from main to jamesmoore/arch-211-add-logging-to-silo November 18, 2024 14:22
@jimmyaxod jimmyaxod force-pushed the jamesmoore/logging branch 6 times, most recently from 90dcf3c to 8cf3f11 Compare November 19, 2024 15:51
@jimmyaxod jimmyaxod force-pushed the jamesmoore/arch-211-add-logging-to-silo branch from b47ef36 to 306f127 Compare November 19, 2024 17:22
Base automatically changed from jamesmoore/arch-211-add-logging-to-silo to main November 19, 2024 17:24
Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>
Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>
Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>
Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>
Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>
Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>
@jimmyaxod jimmyaxod changed the base branch from main to jamesmoore/arch-212-silo-metrics November 19, 2024 20:12
Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>
Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>
Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>
Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>

Added logging to nbd, tidied up nbd config

Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>

Added logging to device

Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>

Added log for connect/serve commands

Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>

storage logger now uses loopholelabs lib

Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>

lint

Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>

Updated with threadsafe bytes buffer for log in tests

Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>

nbd dispatch returns fatal errors to caller

Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>

Added optional logging to waiting cache.

Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>

Added metrics to ProtocolRW and ToProtocol. Logged in cmd/serve

Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>

lint fix

Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>

Added metrics to waitingcache

Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>

connect now logs protocol metrics at end

Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>

Added metrics to FromProtocol and logs at end of cmd/connect

Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>

Added metrics for nbd expose. Logged in cmd/serve

Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>

Latest metrics

Added metrics on dirtyTracker

Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>

Added metrics to volatilitymonitor

Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>

Added general provider metrics

Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>

Added other toProtocol metris

Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>

metrics tidy and new buffered writer

Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>

Add buffered writer option delay timer

Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>

RW can now use buffering

Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>

Buffered writer working

Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>

Fix

Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>

nbd lock

Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>

Added nbd and waitingcache metrics

Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>

Removed buffered write and rebase to new log pr

Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>

Removed write buffer bits

Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>
Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>
@jimmyaxod jimmyaxod force-pushed the jamesmoore/arch-212-silo-metrics branch from 352be07 to fda813a Compare November 20, 2024 17:30
@jimmyaxod
Copy link
Contributor Author

Done in arch-211-add-logging-to-silo and #55

@jimmyaxod jimmyaxod closed this Nov 22, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Nov 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant