Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerize #342

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Dockerize #342

wants to merge 1 commit into from

Conversation

ukazap
Copy link

@ukazap ukazap commented Jun 23, 2023

Building image

cd safaribooks
docker build . -t safaribooks

Usage

Unlike other PRs (#242, #25, #328), the proposed Dockerfile takes a minimal approach (setting the entrypoint to python safaribooks.py without prepending any default/extra arguments) so that the user can run the image using almost the same command shown in the README.md, e.g.

cd safaribooks
python3 safaribooks.py --cred "my_email@gmail.com:MyPassword1!" 9781491958698

using the Docker image:

mkdir -p Books
docker run --rm -v $(pwd)/Books:/app/Books safaribooks --cred "my_email@gmail.com:MyPassword1!" 9781491958698

```
cd safaribooks
docker build . -t safaribooks
```

```
mkdir -p Books
docker run --rm -v $(pwd)/Books:/app/Books safaribooks --cred "my_email@gmail.com:MyPassword1!" 9781491958698
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant