Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ConfigurationKey values up to 1000 chars #258

Closed
wants to merge 1 commit into from

Conversation

andig
Copy link
Contributor

@andig andig commented Mar 13, 2024

Fix evcc-io/evcc#12901

Seems there are boxes sending >500 characters...

@lorenzodonini
Copy link
Owner

This does go against the spec (just to quote you on this topic #240 (comment)).
Then again this change would be harmless, until it remains constrained to configuration values, so that vendors can pass enormous JSON files in custom config 😅

To accept this, the unit test needs to be fixed accordingly though.

@andig
Copy link
Contributor Author

andig commented Mar 18, 2024

Agreed regarding spec. Workaround is to not use getConfiguration in the case. Retracting, thank you!

@andig andig closed this Mar 18, 2024
@premultiply
Copy link
Contributor

Workaround is to not use getConfiguration in the case.

That might be an expensive workaround. Even not usable in some cases.

I think it would be fine to accepting the double size of each value inside getConfiguration items for improved compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error connecting Wallbox Copper Business Charger
3 participants