feat(types): functions must be wrapped in functions

[marcvincenti]

When a provider require an injectable extending a function signature, this function needs to be wrapped by another function since the module will automatically call the former function to instanciate the injectable.

Dependencies can be of type T | (args?: any) => T, we propose to narrow this type to only (args?: any) => T when T is a function.

[LaurentAtGreenly]

it is not quite the same. Factories have only one argument

[marcvincenti]

Yes, i took an unnecessary shortcut by sharing a generic Function type. I removed it from this PR.
Edit: and wrong shortcut

[LaurentAtGreenly]

Looks good Marc. Thanks for the contribution

[marcvincenti]

Thank you for your review and all your propositions. 🙏
I was having a hard time to name the new type WrapFunctionInjectable 😅
I have integrated them all in a review commit.

[marcvincenti]

EDIT: fixed and I added a test for this case

I'm noticing a weird behavior when a provider require a dependency being directly an union type (it works fine with a function that return an union type).

I cannot inject the dependency wrapped in a function because of a weird TS behavior that split the type of (deps: any) => T.

Example:

createProvider({
  injectables: {
    foo: ({ bar }: { bar: 'a' | 'b' }) => bar,
    bar: (): 'a' | 'b' => 'a', // <-- Type '() => "a" | "b"' is not assignable to type '"b" | "a" | ((deps?: any) => "b") | ((deps?: any) => "a")'.
  },
  api: ['foo'],
});

[lorenzofox3]

Not sure why you use an array. But, indeed, your test with the union fails if you don't 😅