Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor german language pack #45

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Refactor german language pack #45

merged 1 commit into from
Feb 2, 2024

Conversation

brainformatik
Copy link
Contributor

  • Refactor german translation
  • Refactor unit tests for german translation

MarkSackerberg
MarkSackerberg reviewed Feb 2, 2024
View reviewed changes
src/lang/de/fields.php
'multiple_per_increment' => ':count Stunden aus :increment',
'times_per_increment' => ':times mal alle :increment Stunden',
'times_per_increment' => ':timesmal alle :increment Stunden',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lorisleiva technically this is correct. Does php translate the var correctly like this or is the space required for different reasons?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your help Mark! Yes, PHP is happy with this as it's just a simple find and replace for the substring :variable.

MarkSackerberg
MarkSackerberg approved these changes Feb 2, 2024
View reviewed changes
Copy link

@MarkSackerberg MarkSackerberg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the one comment where I am unsure on PHP specifics this is looking very good.

lorisleiva
lorisleiva approved these changes Feb 2, 2024
View reviewed changes
Copy link
Owner

@lorisleiva lorisleiva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! 🍻

@lorisleiva lorisleiva merged commit 3c7d8e3 into lorisleiva:main Feb 2, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lorisleiva lorisleiva lorisleiva approved these changes

@MarkSackerberg MarkSackerberg MarkSackerberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brainformatik @lorisleiva @MarkSackerberg