Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: sync selections #10

Merged
merged 8 commits into from
Apr 29, 2024
Merged

Feat: sync selections #10

merged 8 commits into from
Apr 29, 2024

Conversation

zxch3n
Copy link
Member

@zxch3n zxch3n commented Apr 17, 2024

No description provided.

Copy link
Contributor

github-actions bot commented Apr 17, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 43.23% 588 / 1360
🔵 Statements 43.23% 588 / 1360
🔵 Functions 66.66% 20 / 30
🔵 Branches 69.29% 79 / 114
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
index.ts 0% 0% 0% 0% 1
examples/stories/tailwind.config.js 0% 0% 0% 0% 1-8
examples/stories/src/App.tsx 0% 0% 0% 0% 1-35
examples/stories/src/main.tsx 0% 0% 0% 0% 1-10
examples/stories/src/stories/Editor.stories.tsx 0% 0% 0% 0% 1-70
examples/stories/src/stories/Editor.tsx 0% 0% 0% 0% 1-60
src/awareness.ts 0% 0% 0% 0% 1-53
src/cursor-plugin.ts 0% 0% 0% 0% 1-288
src/index.ts 0% 0% 0% 0% 1-4
src/lib.ts 88.82% 75.96% 100% 88.82% 108-109, 120-123, 128-129, 138-141, 146, 154-155, 202-203, 215-216, 245, 287-297, 314, 364, 368-369, 384, 388-389, 441-442, 464-472, 476-477, 586-587, 589, 591, 593, 603-614, 622, 624-628
src/sync-plugin.ts 0% 0% 0% 0% 1-169
Generated in workflow #20

@zxch3n zxch3n changed the title Feat: sync selections WIP: Feat: sync selections Apr 17, 2024
@zxch3n zxch3n requested review from bellini666 and patrick91 and removed request for bellini666 and patrick91 April 19, 2024 13:36
Copy link
Member

@bellini666 bellini666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some suggestions and some questions, but looking good in general :)

Can't do a much deeper typescript review as I'm not an expert with it =P

Btw, there are some commented out console.log statements that you might want to remove before merging

examples/stories/README.md Outdated Show resolved Hide resolved
examples/stories/index.html Outdated Show resolved Hide resolved
src/awareness.ts Outdated Show resolved Hide resolved
src/awareness.ts Outdated Show resolved Hide resolved
src/cursor-plugin.ts Outdated Show resolved Hide resolved
src/cursor-plugin.ts Outdated Show resolved Hide resolved
src/cursor-plugin.ts Outdated Show resolved Hide resolved
src/lib.ts Show resolved Hide resolved
@zxch3n zxch3n changed the title WIP: Feat: sync selections Feat: sync selections Apr 29, 2024
@zxch3n zxch3n merged commit 56a7625 into main Apr 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants