Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

my improvements #69

Merged
merged 3 commits into from
Sep 22, 2024
Merged

my improvements #69

merged 3 commits into from
Sep 22, 2024

Conversation

vfosnar
Copy link
Contributor

@vfosnar vfosnar commented Sep 22, 2024

Hi, I'm using clippy to format the code and it seems it affected some of the files I touched, hope it's not a big problem.

  • respect building:colour and roof:colour - get_block_for_color
  • fix parsing height for values containing m suffix
  • raise height calculation from levels * 3 to levels * 4
  • offset floors by 2 to match with the windows
  • simple information=board implementation

@vfosnar vfosnar changed the title respect building:colour and roof:colour respect building:colour and roof:colour, fix parsing height for values containing m suffix Sep 22, 2024
@vfosnar vfosnar changed the title respect building:colour and roof:colour, fix parsing height for values containing m suffix respect building:colour and roof:colour, fix parsing height for values containing m suffix, raise height calculation from levels * 3 to levels * 4 Sep 22, 2024
@vfosnar vfosnar changed the title respect building:colour and roof:colour, fix parsing height for values containing m suffix, raise height calculation from levels * 3 to levels * 4 my improvements Sep 22, 2024
@louis-e
Copy link
Owner

louis-e commented Sep 22, 2024

Hi there, thank you so much for your contribution! I really appreciate it.
Looks good to me, I'll merge it! I'm currently working on a more memory efficient handling of the chunks in world_editor.rs, as soon as this is finished I'll create a new release including your changes.

@louis-e louis-e merged commit 38aa80b into louis-e:main Sep 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants