fix chunk file in wrong location #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scd31
commented
Oct 16, 2024
| ) | ||
| .unwrap() | ||
| .progress_chars("█▓░"), | ||
| ); | ||
|
|
||
| let mut chunks_to_process = self.chunks_to_modify.clone(); // Clone to prevent modifying while iterating |
There was a problem hiding this comment.
Getting rid of this clone cut RAM usage roughly in half (:
Merged
|
Thank you for your amazing contributions. This PR, along with your others, is laying a great foundation for future enhancements and improvements! |
|
Happy to help! It's a super cool project to work on! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP as I need to clean up the code and fix the progress bar. It's my bed time, I'll try to get that done tomorrow.
There were two separate problems here.
Fixes #53 and #38