-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add @People feature in DingTalk notifications #5464
base: master
Are you sure you want to change the base?
Add @People feature in DingTalk notifications #5464
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, looks like a reasonable change.
I have left a few changes that I would like to see
1. change input 2. verify input
I have a question, how do I check the required rules in |
required rules? |
Like |
Hi @CommanderStorm, Please help to review again. |
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma
Tick the checkbox if you understand [x]:
Description
Sometimes we need to notify specified users in a webhook instead of all users in Dingtalk, and right now it only supports
@everyone
.According to Doc, we can tell that it supports that feature.
Therefore, this PR adds the feature and adds it to the test message. It supports two ways of specifying:
Type of change
Please delete any options that are not relevant.
Checklist
Screenshots (if any)