Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Readme link #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

kirk-baird
Copy link

Minor change to the README.md to reflect AMCL have change where the repo sits.

Signed-off-by: Kirk Baird <baird.k@outlook.com>
@kirk-baird
Copy link
Author

Force pushed to add Sign-off

@lovesh
Copy link
Owner

lovesh commented Aug 23, 2019

The link in Readme is wrong anyway but AMCL used underneath is https://github.com/miracl/amcl and not https://github.com/apache/incubator-milagro-crypto-rust. I see that miracl/amcl is more frequently updated and maintained by M.Scott. Whats the deal with incubator-milagro-crypto-rust?

@kirk-baird
Copy link
Author

So https://github.com/miracl/amcl/version3/rust simply copied the code from https://github.com/apache/incubator-milagro-crypto-rust.
I was going to reach out to miracl shortly as I have started pushing some changes to the development branch of https://github.com/apache/incubator-milagro-crypto-rust, and I think it would be much more productive if we were all putting out changes together.

Let me know if you think it's a good idea to combined all the work in one place

@lovesh
Copy link
Owner

lovesh commented Aug 28, 2019

@kirk-baird I find the code at https://github.com/miracl/amcl/tree/master/version3/rust more recent than at apache/incubator-milagro-crypto-rust. Do you plan to keep reconciling the changes?

@kirk-baird
Copy link
Author

Yep that the plan, or maybe to see if miracl would also like to push their changes upstream too so we have one consistent repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants