Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This flag catches easy to miss cases like this:
where a
uint8_t
will always be>= 0
:GCC includes this in
-Wextra
, but surprisingly Clang doesn't even include it in-Wpedantic
at the moment and you have to go all the way up to-Weverything
.I haven't tested this because I can't get the CRT repo to build at the moment, but maybe it's simple enough.