[features] Fix minsize feature list order #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfrantz
reviewed
Dec 18, 2024
Comment on lines
+383
to
+372
| # To overwrite the level to minsize with feature flags, it needs to be | ||
| # listed after the compilation modes. | ||
| ":minsize", |
There was a problem hiding this comment.
Based on the flag names in the feature definition (-mllvm), it seems this this may be an LLVM-only feature and this might be an error for GCC-based compilers.
I'd suggest adding this to the feature_set for toolchains where we know the compiler is LLVM. E.g., //platforms/riscv32/features:rv32imcb.
There was a problem hiding this comment.
Thanks, I moved the llvm flags to rv32 features.
Only the last optimization level is effective. To overwrite the level to minsize with the minsize feature flag, the feature needs to be listed after the compilation modes. Change-Id: I63ff18f0b6ae450441708e80abbf7228f031913f Signed-off-by: Yi-Hsuan Deng <yhdeng@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only the last optimization level is effective.
To overwrite the level to Oz with the minsize feature flag, the feature needs to be listed after the compilation modes.