[rtl] Avoid name collision in ibex_pmp.sv #2104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recent versions of Verilator complain about the code that was there because the csr_pmp_cfg argument clashes with a name in ibex_core.sv. What's more, they mean different things! In ibex_core.sv, it was the PMP configuration for the entire core. In the functions, it's the PMP configuration for a single region. This patch adds a "region_" prefix to the names, which fixes both the Verilator warning and my confusion!
rswarbrick
force-pushed
the
pmp-name-collision
branch
from
c52728c to
e81c0c8
Compare
marnovandermaas
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent versions of Verilator complain about the code that was there because the csr_pmp_cfg argument clashes with a name in ibex_core.sv.
What's more, they mean different things! In ibex_core.sv, it was the PMP configuration for the entire core. In the functions, it's the PMP configuration for a single region. This patch adds a "region_" prefix to the names, which fixes both the Verilator warning and my confusion!