[licence-checker] Take Styles From Configuration File #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lenary
force-pushed
the
lenary/comment-styles-in-config
branch
from
8cb9383 to
94beed5
Compare
Signed-off-by: Sam Elliott <selliott@lowrisc.org>
lenary
force-pushed
the
lenary/comment-styles-in-config
branch
from
94beed5 to
ffaa563
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a WIP commit, to allow configuring comment styles from the
.hjsonfile provided to the licence checker, rather than from the python source. This makes adding other configuration styles downstream much easier.One thing I decided to do was to separate out "template suffixes" from the normal file suffixes, which makes the configuration quite a bit cleaner - but the documentation is probably lacking.