Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some bugs in tl_broadcast module #1

Merged
merged 2 commits into from
May 13, 2024
Merged

Fix some bugs in tl_broadcast module #1

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
63ac8b0
Fixing an issue where the MaxSize parameter wasn't taking effect in t…
gmlayer0 May 12, 2024
d786308
Update logic for probe_ack_pending_d in the tl_broadcast module to av…
gmlayer0 May 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions ip/tl/rtl/tl_broadcast.sv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -419,9 +419,7 @@ module tl_broadcast import tl_pkg::*; #(

// Wait for all probes to be acked.
StateInv: begin
if (probe_ack_complete || probe_ack_data_complete) begin
probe_ack_pending_d = probe_ack_pending_q - 1;
end
probe_ack_pending_d = probe_ack_pending_q - probe_ack_complete - probe_ack_data_complete;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!


if (probe_ack_pending_d == 0) begin
// We can return to the caller.
Expand Down Expand Up @@ -498,8 +496,8 @@ module tl_broadcast import tl_pkg::*; #(
assign host_b_valid = |probe_pending_q;
assign host_b.opcode = ProbeBlock;
assign host_b.param = probe_param_q;
assign host_b.size = 6;
assign host_b.address = {address_q[AddrWidth-1:6], 6'd0};
assign host_b.size = MaxSize;
assign host_b.address = {address_q[AddrWidth-1:MaxSize], {MaxSize{1'b0}}};

// Zero or onehot bit mask of currently probing host.
logic [NumCachedHosts-1:0] probe_selected;
Expand Down
Loading