Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rv_dm] Fix an assertion #20928

Merged

Conversation

andreaskurth
Copy link
Contributor

@andreaskurth andreaskurth commented Jan 23, 2024

The assertion is for the same condition as in the pinmux_strap_sampling module. However, as opposed to that module, there are some modifications to the strap_en_i signal resulting in a local version of it (strap_en) and the SVA needs to be formulated for that one instead.

Cherry-picking an urgent commit from #20889 so it can be merged ahead of time while the other commits of that PR are under review and discussion.

The assertion is for the same condition as in the
pinmux_strap_sampling module. However, as opposed to that module,
there are some modifications to the strap_en_i signal resulting in
a local version of it (strap_en) and the SVA needs to be
formulated for that one instead.

Signed-off-by: Michael Schaffner <msf@opentitan.org>
Copy link
Contributor

@vogelpi vogelpi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andreaskurth andreaskurth merged commit da3c947 into lowRISC:integrated_dev Jan 23, 2024
20 checks passed
@andreaskurth andreaskurth deleted the rv_dm-fix-assertion branch January 23, 2024 12:48
@msfschaffner
Copy link
Contributor

Thanks for carrying it over!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants