Add Pinmux PWM test #370
Merged
Add Pinmux PWM test #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marnovandermaas
approved these changes
Dec 19, 2024
This loopback can be physically present on the board for tests on the FPGA, but must be modelled in Verilator simulation by directly connecting the output from PMOD0 pin 8 to PMOD0 pin 10 in `top_verilator.sv`. This will allow the Pinmux PWM test to pass in simulation as well as on FPGA.
This commit introduces a new `pinmux_pwm_test` that will run in CI, which tests that PWM appears to be working correctly when it is muxed over PMOD, and that it doesn't work when disabled via Pinmux. This re-uses the loopback testing code from the PWM tests that reads the PWM output via GPIO to determine the duty cycle and period, and use that to verify that PWM operation is as expected. There is some small refactoring to make that possible, including a fix in which the PWM loopback test was accidentally using hardcoded GPIO 0 instead of the specified pin constant (which was also 0, hence no previous problems). Requires an additional jumper cable to FPGAs to pass the test, which can be optionally disabled by the same `PINMUX_CABLE_CONNECTIONS_AVAILABLE` method as for tests where this was previously required.
AlexJones0
force-pushed
the
pinmux_pwm_test
branch
from
7cb620c to
1753a34
Compare
|
Force push just addresses the typo in the commit message. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the commit messages for more detailed explanations. This PR introduces a new
pinmux_pwm_testwhich tests that a PWM instance can be muxed, and that the existing PWM loopback testing works only when the pinmux is configured correctly. If running in CI, this test would be sufficient to catch the issue fixed in #369.I've tested this on both FPGA and in simulation locally, and the FPGA in CI is already set up with a jumper cable so this test should be passing. I've also added the loopback to the simulation model so this can pass there as well.