-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Known issue: config_display: columns
bad dimensions
#839
Comments
Hello @lowlighter, Regarding the height issue (#814) and config_display (#839), I think instead of directly creating SVG file, we should create HTML code and convert that HTML code to SVG. 🤔 Metrics generated in the case of @Zenoo was https://raw.githubusercontent.com/Zenoo/zenoo/f0eb3da9562b73352d8cb69c310e4b0dcca35938/github-metrics.svg I created corresponding code in HTML of the same (with few changes and I removed SVG & foreignObject dimensions). and Now using this website
|
Actually a similar system is already used: it renders the svg in an html page, compute bounding rect and crop it (btw this is also why the size may differ in the end because it's rendered on ubuntu+chrome+system fonts which may not have same height on other environment). The "height oversize" is actually intentional for now. This mode implies "2 heights": one for 2 columns, one for 1 column. Note that it only happens when embed in an |
When
config_display
option is set tocolumns
, it uses CSS @media queries to adjust width dynamically.However, since height needs to be fixed by the viewbox and height of the SVG, dynamic height resizing is hard (impossible?) to achieve (see #374).
Current workaround is to manually split the image by using multiples jobs, and use
<img align="{left|right|center}">
to embed metrics.If you know how to fix it, feel free to open an issue or comment
The text was updated successfully, but these errors were encountered: