Check http statusCode when delete loxilb's LB rule #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If kube-loxilb fails to create an LB, kube-loxilb attempts to clean up all LB information created so far.
At this time, loxilb returns an error (no rules) with http Status 200 if there is no corresponding LB rule.
Currently, kube-loxilb does not check the status code, so it judges this as a deletion failure.
Therefore, the cleanup also fails.
This causes a state in which external IPs cannot be assigned to services because the IP Pool is not organized.
To prevent this issue I updated the code.