refactor

ls1intum · Dec 2, 2024 · 34c27a0 · 34c27a0
1 parent ea10516
commit 34c27a0
Show file tree

Hide file tree

Showing 3 changed files with 26 additions and 1 deletion.
diff --git a/...main/webapp/app/shared/metis/posting-markdown-editor/posting-markdown-editor.component.ts b/...main/webapp/app/shared/metis/posting-markdown-editor/posting-markdown-editor.component.ts
@@ -126,7 +126,7 @@ export class PostingMarkdownEditorComponent implements OnInit, ControlValueAcces
 
         const editor = this.markdownEditor.monacoEditor;
         if (editor) {
-            editor.onDidChangeModelContent((event: { changes: string | any[] }) => {
+            editor.onDidChangeModelContent((event: monaco.editor.IModelContentChangedEvent) => {
                 const position = editor.getPosition();
                 if (!position) {
                     return;

diff --git a/...omponent/shared/metis/postings-markdown-editor/postings-markdown-editor.component.spec.ts b/...omponent/shared/metis/postings-markdown-editor/postings-markdown-editor.component.spec.ts
@@ -566,4 +566,15 @@ describe('PostingsMarkdownEditor', () => {
 
         expect(handleActionClickSpy).toHaveBeenCalledWith(expect.any(MouseEvent), bulletedListAction);
     });
+
+    it('should handle invalid line content gracefully', () => {
+        const mockModel = {
+            getLineContent: jest.fn().mockReturnValue(''),
+        } as unknown as monaco.editor.ITextModel;
+        const mockPosition = { lineNumber: 1 } as monaco.Position;
+        const handleActionClickSpy = jest.spyOn(component.markdownEditor, 'handleActionClick');
+
+        (component as any).handleKeyDown(mockModel, mockPosition.lineNumber);
+        expect(handleActionClickSpy).not.toHaveBeenCalled();
+    });
 });
diff --git a/src/test/javascript/spec/component/shared/monaco-editor/monaco-editor.component.spec.ts b/src/test/javascript/spec/component/shared/monaco-editor/monaco-editor.component.spec.ts
@@ -313,4 +313,18 @@ describe('MonacoEditorComponent', () => {
         const lineContent = comp.getLineContent(2);
         expect(lineContent).toBe('static void main() {');
     });
+
+    it('should handle invalid line numbers in getLineContent', () => {
+        fixture.detectChanges();
+        comp.setText(multiLineText);
+
+        // Invalid line numbers
+        expect(() => comp.getLineContent(0)).toThrow();
+        expect(() => comp.getLineContent(-1)).toThrow();
+        expect(() => comp.getLineContent(999)).toThrow();
+
+        // Empty line
+        comp.setText('line1\n\nline3');
+        expect(comp.getLineContent(2)).toBe('');
+    });
 });