-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adaptive learning
: Change gif in instructor help in competencies view to video
#10030
base: develop
Are you sure you want to change the base?
Adaptive learning
: Change gif in instructor help in competencies view to video
#10030
Conversation
WalkthroughThe pull request involves updating the Changes
Suggested labels
Suggested reviewers
Possibly related PRs
📜 Recent review detailsConfiguration used: .coderabbit.yaml ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Adaptive Learning
: Change gif in instructor help in competencies view to video
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🧹 Nitpick comments (1)
src/main/webapp/app/course/competencies/components/course-competency-explanation-modal/course-competency-explanation-modal.component.html (1)
Line range hint
27-44
: Consider performance optimization for video assetsWhile videos provide better user control and potentially clearer instructions than GIFs, consider these performance optimizations:
- Compress videos appropriately to balance quality and file size
- Consider using the
preload="metadata"
attribute (as suggested above) to defer loading- Consider generating WebM versions as a modern alternative format
Would you like assistance in setting up a video optimization pipeline for these assets?
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (4)
src/main/resources/public/videos/course-competencies/create-competencies.gif
is excluded by!**/*.gif
,!**/*.gif
src/main/resources/public/videos/course-competencies/create-competencies.mp4
is excluded by!**/*.mp4
,!**/*.mp4
src/main/resources/public/videos/course-competencies/create-course-competency-relations.gif
is excluded by!**/*.gif
,!**/*.gif
src/main/resources/public/videos/course-competencies/create-course-competency-relations.mp4
is excluded by!**/*.mp4
,!**/*.mp4
📒 Files selected for processing (1)
src/main/webapp/app/course/competencies/components/course-competency-explanation-modal/course-competency-explanation-modal.component.html
(2 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
...nents/course-competency-explanation-modal/course-competency-explanation-modal.component.html
Outdated
Show resolved
Hide resolved
...nents/course-competency-explanation-modal/course-competency-explanation-modal.component.html
Outdated
Show resolved
Hide resolved
Adaptive Learning
: Change gif in instructor help in competencies view to videoAdaptive learning
: Change gif in instructor help in competencies view to video
There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions. |
517201a
to
e2e6fed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 🚀
6b8a890
e2e6fed
to
6b8a890
Compare
6b8a890
to
179af8f
Compare
Checklist
General
Client
Motivation and Context
The gif in instructor intro view for competencies is hard to understand/follow
Closes #9676
Description
I have replaced the gif in the intro view to a video.
Steps for Testing
Prerequisites:
Testserver States
Note
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.
Review Progress
Performance Review
Code Review
Manual Tests
Exam Mode Test
Performance Tests
Test Coverage
Screenshots
Summary by CodeRabbit