-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Programming exercises
: Add simple mode to create and edit view
#9283
Programming exercises
: Add simple mode to create and edit view
#9283
Conversation
Feature
: Add simple mode to programming exercisesProgramming exercises
: Add simple mode to edit view
Change requests were addressed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reapprove code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on TS3, re-approve.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reapproved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on TS3. Reapprove
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
retested on TS3, lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reapprove
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on TS3 and reapprove
Checklist
General
Client
Motivation and Context
Programming exercises offer diverse configuration options and can be overwhelming to configure for new users (new instructors).
This PR should allow instructors to lower the learning curve for the configuration programming exercises, allowing new instructors to get started with creating basic programming exercises.
If advanced features are needed, it is easy to switch to the advanced mode for the respective configuration detail.
The current selection of configuration options is a starting point, as multiple different opinions are likely to be present, some which might not have been considered yet, it shall be simple to adjust the configuration option that are available in the simple mode (modification via a simple datastructure).
Description
simple mode
for the configuration of programming exercises that displays a reduced subset of configuration optionssimple mode
and theadvanced mode
programming-exercise-update.helper.ts
) to easily allow a modification of which fields are displayed in thesimple mode
/advanced mode
(this also includes adding a bunch of if checks in the respective template parts)isEdit
variable inprogramming-exercise-update.component.ts
isSimpleMode
value in thelocalStorage
to keep the mode after a page reloadcategory-selector.component.ts
exerciseTitle
(for all exercise types) andshortName
Note
isSimpleMode
, which are called in the template withisSimpleMode()
to access the respective value. This is not a standard function call that would need to be prevented in the template.Steps for Testing
Prerequisites:
simple mode
Short Name
was createdsimple mode
and theadvanced mode
works as expectedTestserver States
Note
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.
Review Progress
Code Review
Manual Tests
Test Coverage
Link to E2E tests Playwright (MySQL, Local)
Client
Screenshots
New
New
simple mode
with option to switch to theadvanced mode
and backScreencast:
Screenshots:
Old
Summary by CodeRabbit
Summary by CodeRabbit
New Features
ProgrammingExerciseInformationComponent
for enhanced management of programming exercises.Enhancements
Localization
Tests
ProgrammingExerciseInformationComponent
.