-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Development
: Migrate the online code editor to a standalone component
#9505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
tests
client
Pull requests that update TypeScript code. (Added Automatically!)
labels
Oct 16, 2024
pzdr7
temporarily deployed
to
artemis-test1.artemis.cit.tum.de
October 16, 2024 23:06
— with
GitHub Actions
Inactive
Cathy0123456789
approved these changes
Oct 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on TS5. Works great.
Feras797
reviewed
Oct 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
krusche
approved these changes
Oct 24, 2024
This was referenced Oct 24, 2024
Merged
Merged
This was referenced Nov 2, 2024
This was referenced Nov 9, 2024
This was referenced Nov 16, 2024
This was referenced Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
General
Client
Changes affecting Programming Exercises
Motivation and Context
Modernize the component to better follow the client coding guidelines.
Description
Steps for Testing
Prerequisites:
Participation:
(Known issue: resizing the editor may be a bit slow. this is generally a bug in the code editor grid and not related to this PR)
Assessment:
Testserver States
Note
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.
Review Progress
Code Review
Manual Tests
Test Coverage
Client
Screenshots
No UI changes
Summary by CodeRabbit
New Features
CodeEditorHeaderComponent
with improved input handling and event binding.CodeEditorMonacoComponent
with reactive programming features for better state management.Bug Fixes
Documentation
Tests